From: Andrew Morton <akpm@linux-foundation.org>
To: "Kassey Li (QUIC)" <quic_yingangl@quicinc.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] mm/cma_debug.c: align the name buffer length as struct cma
Date: Wed, 20 Jul 2022 10:02:43 -0700 [thread overview]
Message-ID: <20220720100243.7c1151a71ae8400b81d46130@linux-foundation.org> (raw)
In-Reply-To: <CO6PR02MB8753B9C4BAA3ABF34508DBABEF8E9@CO6PR02MB8753.namprd02.prod.outlook.com>
On Wed, 20 Jul 2022 10:45:33 +0000 "Kassey Li (QUIC)" <quic_yingangl@quicinc.com> wrote:
> Hi, Andrew:
>
> Is it the case that the output is never >16 chars anyway? If so, we'll be OK.
> >> Yes. I verified on my device by giving cma.name length l< 16 and >16 both. Result is OK. I mean > 16 showed correctly with this patch.
> >> without this patch, cma.name > 16, only showed 16 characters.
>
Well that's my point. With this patch the output is changed and this
might break userspace code which expects the truncation.
That should be OK as there are no guarantees with debugfs interfaces.
I added this as the patch's changelog:
: Avoids truncating the debugfs output to 16 chars. Potentially alters
: the userspace output, but this is a debugfs interface and there are no
: stability guarantees.
prev parent reply other threads:[~2022-07-20 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:15 Kassey Li
2022-07-19 23:18 ` Andrew Morton
2022-07-20 10:45 ` Kassey Li (QUIC)
2022-07-20 17:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720100243.7c1151a71ae8400b81d46130@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=quic_yingangl@quicinc.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®