From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAB7C433EF for ; Fri, 22 Jul 2022 08:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234663AbiGVIJd (ORCPT ); Fri, 22 Jul 2022 04:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234256AbiGVIJc (ORCPT ); Fri, 22 Jul 2022 04:09:32 -0400 Received: from hetzy.fluff.org (test-v6.fluff.org [IPv6:2a01:4f8:222:2004::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316299B9E9 for ; Fri, 22 Jul 2022 01:09:31 -0700 (PDT) Received: from ben by hetzy.fluff.org with local (Exim 4.89) (envelope-from ) id 1oEnb1-0004YL-H3; Fri, 22 Jul 2022 09:01:15 +0100 Date: Fri, 22 Jul 2022 09:01:15 +0100 From: Ben Dooks To: Christoph Hellwig Cc: Ben Dooks , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kallsyms: make arch_get_kallsym() static Message-ID: <20220722080115.pzryb7dy2ijbp6p7@hetzy.fluff.org> References: <20220721151040.359389-1-ben-linux@fluff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Disclaimer: These are my views alone. X-URL: http://www.fluff.org/ User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@fluff.org X-SA-Exim-Scanned: No (on hetzy.fluff.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 08:22:39AM -0700, Christoph Hellwig wrote: > On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote: > > The arch_get_kallsym() function is not used anywhere in the kernel > > now, so it should at-least be static or just be removed as there > > are no users. Making it static fixes the following sparse warning: > > > > kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static? > > It fixes the warning, but isn't exactly useful. Please just remove it, > get_ksymbol_arch and iter->pos_arch_end entirely instead. Ok, probably the best. I didn't have time to do any archeaology on it to find out if it has ever been used. -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.