From: Melissa Wen <mwen@igalia.com>
To: Danilo Krummrich <dakr@redhat.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, mripard@kernel.org,
christian.koenig@amd.com, emma@anholt.net,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND 08/10] drm/v3d: use idr_init_base() to initialize v3d_priv->perfmon.idr
Date: Sat, 23 Jul 2022 21:45:00 -0100 [thread overview]
Message-ID: <20220723224500.w6pezv3ojgu2d6qi@mail.igalia.com> (raw)
In-Reply-To: <20220720132830.193747-9-dakr@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On 07/20, Danilo Krummrich wrote:
> idr_init_base(), implemented by commit 6ce711f27500 ("idr: Make 1-based
> IDRs more efficient"), let us set an arbitrary base other than
> idr_init(), which uses base 0.
>
> Since, for this IDR, no ID < 1 is ever requested/allocated, using
> idr_init_base(&idr, 1) avoids unnecessary tree walks.
>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
> index f6a88abccc7d..48aaaa972c49 100644
> --- a/drivers/gpu/drm/v3d/v3d_perfmon.c
> +++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
> @@ -95,7 +95,7 @@ struct v3d_perfmon *v3d_perfmon_find(struct v3d_file_priv *v3d_priv, int id)
> void v3d_perfmon_open_file(struct v3d_file_priv *v3d_priv)
> {
> mutex_init(&v3d_priv->perfmon.lock);
> - idr_init(&v3d_priv->perfmon.idr);
> + idr_init_base(&v3d_priv->perfmon.idr, 1);
Reviewed-by: Melissa Wen <mwen@igalia.com>
Thanks
> }
>
> static int v3d_perfmon_idr_del(int id, void *elem, void *data)
> --
> 2.36.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-23 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 13:28 [PATCH RESEND 00/10] drm: use idr_init_base() over idr_init() if applicable Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 01/10] drm/amdgpu: use idr_init_base() to initialize mgr->ctx_handles Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 02/10] drm/amdgpu: use idr_init_base() to initialize fpriv->bo_list_handles Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 03/10] drm: use idr_init_base() to initialize master->magic_map Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 04/10] drm: use idr_init_base() to initialize master->lessee_idr Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 05/10] drm: use idr_init_base() to initialize mode_config.object_idr Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 06/10] drm: use idr_init_base() to initialize mode_config.tile_idr Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 07/10] drm/sis: use idr_init_base() to initialize dev_priv->object_idr Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 08/10] drm/v3d: use idr_init_base() to initialize v3d_priv->perfmon.idr Danilo Krummrich
2022-07-23 22:45 ` Melissa Wen [this message]
2022-07-20 13:28 ` [PATCH RESEND 09/10] drm/via: use idr_init_base() to initialize dev_priv->object_idr Danilo Krummrich
2022-07-20 13:28 ` [PATCH RESEND 10/10] drm/todo: remove task for idr_init_base() Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723224500.w6pezv3ojgu2d6qi@mail.igalia.com \
--to=mwen@igalia.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®