From: Alain Volmat <alain.volmat@foss.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <alexandre.torgue@foss.st.com>, <robh+dt@kernel.org>,
<mcoquelin.stm32@gmail.com>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<amelie.delaunay@foss.st.com>
Subject: Re: [PATCH 1/2] ARM: dts: stm32: add spi nodes into stm32mp131.dtsi
Date: Mon, 25 Jul 2022 09:51:20 +0200 [thread overview]
Message-ID: <20220725075120.GA429410@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <c7e13adb-8584-6e24-11f3-9a27c7122da4@linaro.org>
Hi Krzysztof,
thanks for the review. Will push a v2 fixing those points.
Alain
On Thu, Jul 21, 2022 at 06:32:18PM +0200, Krzysztof Kozlowski wrote:
> On 21/07/2022 17:34, Alain Volmat wrote:
> > Add the 5 instances of spi busses supported by the stm32mp131.
> >
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> > arch/arm/boot/dts/stm32mp131.dtsi | 70 +++++++++++++++++++++++++++++++
> > 1 file changed, 70 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
> > index da9e8a6ca663..db3d1b900d5c 100644
> > --- a/arch/arm/boot/dts/stm32mp131.dtsi
> > +++ b/arch/arm/boot/dts/stm32mp131.dtsi
> > @@ -97,6 +97,34 @@ scmi_shm: scmi-sram@0 {
> > };
> > };
> >
> > + spi2: spi@4000b000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "st,stm32h7-spi";
> > + reg = <0x4000b000 0x400>;
>
> Unusual order... rather first compatible then reg.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-07-25 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:34 [PATCH 0/2] ARM: dts: stm32: add SPI on STM32MP13 platform Alain Volmat
2022-07-21 15:34 ` [PATCH 1/2] ARM: dts: stm32: add spi nodes into stm32mp131.dtsi Alain Volmat
2022-07-21 16:32 ` Krzysztof Kozlowski
2022-07-25 7:51 ` Alain Volmat [this message]
2022-07-21 15:34 ` [PATCH 2/2] ARM: dts: stm32: add pinctrl and disabled spi5 node in stm32mp135f-dk Alain Volmat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725075120.GA429410@gnbcxd0016.gnb.st.com \
--to=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®