From: Wei Liu <wei.liu@kernel.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: Michael Kelley <mikelley@microsoft.com>,
sthemmin@microsoft.com, kys@microsoft.com,
haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
will@kernel.org, robin.murphy@arm.com, samuel@sholland.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
iommu@lists.linux.dev
Subject: Re: [PATCH 1/1] iommu/hyper-v: Use helper instead of directly accessing affinity
Date: Tue, 26 Jul 2022 13:09:09 +0000 [thread overview]
Message-ID: <20220726130909.jnj5etogffm4b2c5@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <Yt+Uro8y219/MNFE@8bytes.org>
On Tue, Jul 26, 2022 at 09:15:58AM +0200, Joerg Roedel wrote:
> Hi Michael,
>
> On Mon, Jul 25, 2022 at 05:53:40PM -0700, Michael Kelley wrote:
> > Recent changes to solve inconsistencies in handling IRQ masks #ifdef
> > out the affinity field in irq_common_data for non-SMP configurations.
> > The current code in hyperv_irq_remapping_alloc() gets a compiler error
> > in that case.
> >
> > Fix this by using the new irq_data_update_affinity() helper, which
> > handles the non-SMP case correctly.
> >
> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>
> Please add a fixes tag.
>
> Where is the change which breaks this currently, in some subsystem tree
> or already upstream?
>
The offending patch aa081358 is in linux-next.
> In case it is still in a maintainers tree, this patch should be applied
> there. Here is my
>
> Acked-by: Joerg Roedel <jroedel@suse.de>
I can take this patch via hyperv-next. This is a good improvement
anyway.
Thanks,
Wei.
>
> for that.
>
next prev parent reply other threads:[~2022-07-26 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 0:53 Michael Kelley
2022-07-26 2:39 ` Randy Dunlap
2022-07-26 3:34 ` Michael Kelley (LINUX)
2022-08-03 16:26 ` Michael Kelley (LINUX)
2022-08-04 9:03 ` Marc Zyngier
2022-07-26 7:15 ` Joerg Roedel
2022-07-26 13:09 ` Wei Liu [this message]
2022-07-26 13:48 ` Michael Kelley (LINUX)
2022-07-26 14:38 ` Wei Liu
2022-08-04 13:26 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726130909.jnj5etogffm4b2c5@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=sthemmin@microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®