mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Lifu <chenlifu@huawei.com>
To: <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <chenlifu@huawei.com>
Subject: [PATCH v2 -next] genirq: Separate warning messages of enable of suspended irq
Date: Thu, 28 Jul 2022 18:29:12 +0800	[thread overview]
Message-ID: <20220728102912.474772-1-chenlifu@huawei.com> (raw)

Both unbalanced enable for irq and enable of suspended irq
print same warning messages, such as:
......
[20220314100142]------------[ cut here ]------------
[20220314100142]WARNING: CPU: 1 PID: 10332 at kernel/irq/manage.c:723 __enable_irq+0x58/0xa4
[20220314100142]Unbalanced enable for IRQ 38
......

It's confusing. Separate the warning messages to make it clear.
No functional changes.

Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
 kernel/irq/manage.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 40fe7806cc8c..bf4f5f63b2d3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -775,17 +775,19 @@ void disable_nmi_nosync(unsigned int irq)
 
 void __enable_irq(struct irq_desc *desc)
 {
 	switch (desc->depth) {
 	case 0:
- err_out:
 		WARN(1, KERN_WARNING "Unbalanced enable for IRQ %d\n",
 		     irq_desc_get_irq(desc));
 		break;
 	case 1: {
-		if (desc->istate & IRQS_SUSPENDED)
-			goto err_out;
+		if (desc->istate & IRQS_SUSPENDED) {
+			WARN(1, KERN_WARNING "Enable of suspended IRQ %d\n",
+			     irq_desc_get_irq(desc));
+			break;
+		}
 		/* Prevent probing on this irq: */
 		irq_settings_set_noprobe(desc);
 		/*
 		 * Call irq_startup() not irq_enable() here because the
 		 * interrupt might be marked NOAUTOEN. So irq_startup()
-- 
2.37.0


             reply	other threads:[~2022-07-28 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 10:29 Chen Lifu [this message]
2022-09-20  6:42 ` chenlifu
2022-10-31  0:39   ` chenlifu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728102912.474772-1-chenlifu@huawei.com \
    --to=chenlifu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®