From: Tariq Toukan <tariqt@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
<linux-kernel@vger.kernel.org>, Tariq Toukan <tariqt@nvidia.com>,
Christian Benvenuti <benve@cisco.com>,
"Govindarajulu Varadarajan" <_govind@gmx.com>
Subject: [PATCH net-next V4 3/3] enic: Use NUMA distances logic when setting affinity hints
Date: Thu, 28 Jul 2022 22:12:03 +0300 [thread overview]
Message-ID: <20220728191203.4055-4-tariqt@nvidia.com> (raw)
In-Reply-To: <20220728191203.4055-1-tariqt@nvidia.com>
Use the new CPU spread API to sort cpus preference of remote NUMA nodes
according to their distance.
Cc: Christian Benvenuti <benve@cisco.com>
Cc: Govindarajulu Varadarajan <_govind@gmx.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/cisco/enic/enic_main.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index 372fb7b3a282..9de3c3ffa1e3 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -44,6 +44,7 @@
#include <linux/cpu_rmap.h>
#endif
#include <linux/crash_dump.h>
+#include <linux/sched/topology.h>
#include <net/busy_poll.h>
#include <net/vxlan.h>
@@ -114,8 +115,14 @@ static struct enic_intr_mod_range mod_range[ENIC_MAX_LINK_SPEEDS] = {
static void enic_init_affinity_hint(struct enic *enic)
{
int numa_node = dev_to_node(&enic->pdev->dev);
+ u16 *cpus;
int i;
+ cpus = kcalloc(enic->intr_count, sizeof(*cpus), GFP_KERNEL);
+ if (!cpus)
+ return;
+
+ sched_cpus_set_spread(numa_node, cpus, enic->intr_count);
for (i = 0; i < enic->intr_count; i++) {
if (enic_is_err_intr(enic, i) || enic_is_notify_intr(enic, i) ||
(cpumask_available(enic->msix[i].affinity_mask) &&
@@ -123,9 +130,10 @@ static void enic_init_affinity_hint(struct enic *enic)
continue;
if (zalloc_cpumask_var(&enic->msix[i].affinity_mask,
GFP_KERNEL))
- cpumask_set_cpu(cpumask_local_spread(i, numa_node),
+ cpumask_set_cpu(cpus[i],
enic->msix[i].affinity_mask);
}
+ kfree(cpus);
}
static void enic_free_affinity_hint(struct enic *enic)
--
2.21.0
prev parent reply other threads:[~2022-07-28 19:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:12 [PATCH net-next V4 0/3] Introduce and use NUMA distance metrics Tariq Toukan
2022-07-28 19:12 ` [PATCH net-next V4 1/3] sched/topology: Add NUMA-based CPUs spread API Tariq Toukan
2022-07-30 17:29 ` Tariq Toukan
2022-08-02 6:40 ` Tariq Toukan
2022-08-02 9:38 ` Valentin Schneider
2022-08-02 16:05 ` Jakub Kicinski
2022-08-04 17:28 ` Valentin Schneider
2022-08-08 14:39 ` Tariq Toukan
2022-08-09 10:02 ` Valentin Schneider
2022-08-09 10:18 ` Tariq Toukan
2022-08-09 12:52 ` Valentin Schneider
2022-08-09 14:04 ` Tariq Toukan
2022-08-09 17:36 ` Valentin Schneider
2022-08-10 10:46 ` Valentin Schneider
2022-08-10 10:51 ` [PATCH 1/2] sched/topology: Introduce sched_numa_hop_mask() Valentin Schneider
2022-08-10 10:51 ` [PATCH 2/2] net/mlx5e: Leverage sched_numa_hop_mask() Valentin Schneider
2022-08-10 12:57 ` Tariq Toukan
2022-08-10 17:42 ` Jakub Kicinski
2022-08-11 14:26 ` Valentin Schneider
2022-08-10 12:42 ` [PATCH 1/2] sched/topology: Introduce sched_numa_hop_mask() Tariq Toukan
2022-08-10 12:57 ` Tariq Toukan
2022-08-11 14:26 ` Valentin Schneider
2022-08-14 8:19 ` Tariq Toukan
2022-08-14 8:26 ` Tariq Toukan
2022-08-15 14:20 ` Valentin Schneider
2022-07-28 19:12 ` [PATCH net-next V4 2/3] net/mlx5e: Improve remote NUMA preferences used for the IRQ affinity hints Tariq Toukan
2022-07-28 19:12 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728191203.4055-4-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=saeedm@nvidia.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®