mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joe Simmons-Talbott <joetalbott@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: Use parens with sizeof
Date: Sun, 31 Jul 2022 12:30:39 +0100	[thread overview]
Message-ID: <20220731123039.600347b0@jic23-huawei> (raw)
In-Reply-To: <20220717153438.10800-1-joetalbott@gmail.com>

On Sun, 17 Jul 2022 11:34:38 -0400
Joe Simmons-Talbott <joetalbott@gmail.com> wrote:

> Prefer 'sizeof(var)' over 'sizeof var' as reported by checkpatch.pl.
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
to let 0-day take a poke at it.

oops. Email got stuck in my outbox when I went away for a week.

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-trigger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index f504ed351b3e..88bccb0676c8 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -368,7 +368,7 @@ struct iio_poll_func
>  	va_list vargs;
>  	struct iio_poll_func *pf;
>  
> -	pf = kmalloc(sizeof *pf, GFP_KERNEL);
> +	pf = kmalloc(sizeof(*pf), GFP_KERNEL);
>  	if (pf == NULL)
>  		return NULL;
>  	va_start(vargs, fmt);
> @@ -560,7 +560,7 @@ struct iio_trigger *viio_trigger_alloc(struct device *parent,
>  	struct iio_trigger *trig;
>  	int i;
>  
> -	trig = kzalloc(sizeof *trig, GFP_KERNEL);
> +	trig = kzalloc(sizeof(*trig), GFP_KERNEL);
>  	if (!trig)
>  		return NULL;
>  


      parent reply	other threads:[~2022-07-31 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 15:34 Joe Simmons-Talbott
2022-07-17 17:08 ` Joe Perches
2022-07-17 20:08   ` Joe Simmons-Talbott
2022-07-18  1:25     ` Joe Perches
2022-07-31 11:30 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220731123039.600347b0@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=joetalbott@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®