From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: linux-spi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, bert@biot.com,
sander@svanheule.net, mail@birger-koblitz.de,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH v3 0/2] spi: realtek-rtl: two small improvements
Date: Sun, 31 Jul 2022 22:21:50 +0200 [thread overview]
Message-ID: <20220731202152.1358252-1-martin.blumenstingl@googlemail.com> (raw)
This is a successor to my single patch [0] "spi: realtek-rtl: Fix
clearing some register bits"
Changes since v2 at [1]:
- Added Sander's Tested-by to the second patch (thank you!)
- Dropped HAS_IOMEM dependency as this is already implied by CONFIG_SPI
(thanks Sander for spotting this!)
- Extended Kconfig help text with the module name to make the Realtek
driver consistent with others. Thanks to Sander for the suggestion!
Changes since v1 at [0]:
- Added new patch to enable compile testing for the spi-realtek-rtl
driver. This makes it easier to verify coding style changes (such as
patch #2 in this series) where the binary result is not supposed to
change.
- Updated the original patch to drop the RTL_SPI_SFCSR_CS change as
it's not fully clear why that code is written as-is (and due to
lack of hardware I am unable to runtime test the changes). Also
move the ~ operator from the RTL_SPI_SFCSR_LEN_MASK definition to
the place where it's used. Thanks to Sander for spotting the mistake
in my initial patch!
[0] https://lore.kernel.org/lkml/78673dc7438a03bf9ed0103a935abf0172f146ce.camel@svanheule.net/T/
[1] https://lore.kernel.org/linux-spi/20220728152118.1429161-1-martin.blumenstingl@googlemail.com/T/
Martin Blumenstingl (2):
spi: realtek-rtl: Add compile testing support
spi: realtek-rtl: Improve readability when clearing the size mask
drivers/spi/Kconfig | 11 +++++++++++
drivers/spi/Makefile | 2 +-
drivers/spi/spi-realtek-rtl.c | 4 ++--
3 files changed, 14 insertions(+), 3 deletions(-)
--
2.37.1
next reply other threads:[~2022-07-31 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 20:21 Martin Blumenstingl [this message]
2022-07-31 20:21 ` [PATCH v3 1/2] spi: realtek-rtl: Add compile testing support Martin Blumenstingl
2022-08-16 19:55 ` Sander Vanheule
2022-07-31 20:21 ` [PATCH v3 2/2] spi: realtek-rtl: Improve readability when clearing the size mask Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220731202152.1358252-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®