mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: zhangduo <zduo006@163.com>
Cc: naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com,
	davem@davemloft.net, mhiramat@kernel.org,
	linux-kernel@vger.kernel.org, zhangduo <zhangduo@kylinos.cn>
Subject: Re: [PATCH 2/2] kprobes: fix the comments error
Date: Sun, 31 Jul 2022 23:37:32 +0900	[thread overview]
Message-ID: <20220731233732.446610618f2f208f13b8e2a1@kernel.org> (raw)
In-Reply-To: <20220722062505.20309-1-zduo006@163.com>

On Fri, 22 Jul 2022 14:25:05 +0800
zhangduo <zduo006@163.com> wrote:

> From: zhangduo <zhangduo@kylinos.cn>
> 
> fix the comments 'Copy the insn slot of ap to p'
> 
> Signed-off-by: zhangduo <zhangduo@kylinos.cn>

Looks good to me. 

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks, 

> ---
>  kernel/kprobes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index f1dddc8fe..8bcef7d3c 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1349,7 +1349,7 @@ static int register_aggr_kprobe(struct kprobe *orig_p, struct kprobe *p)
>  			    | KPROBE_FLAG_DISABLED;
>  	}
>  
> -	/* Copy the insn slot of 'p' to 'ap'. */
> +	/* Copy the insn slot of 'ap' to 'p'. */
>  	copy_kprobe(ap, p);
>  	ret = add_new_kprobe(ap, p);
>  
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

      parent reply	other threads:[~2022-07-31 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22  6:25 zhangduo
2022-07-28 12:41 ` [PATCH 1/2] " zhangduo
2022-07-31 14:37 ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220731233732.446610618f2f208f13b8e2a1@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=zduo006@163.com \
    --cc=zhangduo@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome