mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] make buffer_locked provide an acquire semantics
Date: Sun, 31 Jul 2022 20:20:45 -0700	[thread overview]
Message-ID: <20220801032045.GZ2860372@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <YucGwGr4KTPPxbYJ@casper.infradead.org>

On Sun, Jul 31, 2022 at 11:48:32PM +0100, Matthew Wilcox wrote:
> On Sun, Jul 31, 2022 at 10:30:11AM -0700, Paul E. McKenney wrote:
> > That said, I confess that I am having a hard time finding the
> > buffer_locked() definition.  So if buffer_locked() uses normal C-language
> > accesses to sample the BH_Lock bit of the ->b_state field, then yes,
> > there could be a problem.  The compiler would then be free to reorder
> > calls to buffer_locked() because it could then assume that no other
> > thread was touching that ->b_state field.
> 
> You're having a hard time finding it because it's constructed with the C
> preprocessor.  I really wish we generated header files using CPP once
> and then included the generated/ file.  That would make them greppable.
> 
> You're looking for include/linux/buffer_head.h and it's done like this:
> 
> enum bh_state_bits {
> ...
>         BH_Lock,        /* Is locked */
> ...
> 
> #define BUFFER_FNS(bit, name)                                           \
> ...
> static __always_inline int buffer_##name(const struct buffer_head *bh)  \
> {                                                                       \
>         return test_bit(BH_##bit, &(bh)->b_state);                      \
> }
> 
> BUFFER_FNS(Lock, locked)
> 
> (fwiw, the page/folio versions of these functions don't autogenerate
> the lock or uptodate ones because they need extra functions called)

Thank you!

Another thing that would have helped me find it would have been to leave
the "BH_" prefix on the bit name in the BUFFER_FNS() invocation, as in
ditch the "BH_##" in the definition and then just say "BUFFER_FNS(BH_Lock,
locked)".

But what is life without a challenge?  ;-/

Anyway, on x86 this will use the constant_test_bit() function, which
uses a volatile declaration for its parameter.  So it should avoid
vulnerability to the vicissitudes of the compiler.

So I feel much better now.

							Thanx, Paul

  reply	other threads:[~2022-08-01  3:21 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 11:43 [PATCH] Add a read memory barrier to wait_on_buffer Mikulas Patocka
2022-07-31 12:00 ` Ard Biesheuvel
2022-07-31 13:41   ` Mikulas Patocka
2022-07-31 15:08     ` [PATCH v2] make buffer_locked provide an acquire semantics Mikulas Patocka
2022-07-31 16:51       ` Linus Torvalds
2022-07-31 17:30         ` Paul E. McKenney
2022-07-31 22:48           ` Matthew Wilcox
2022-08-01  3:20             ` Paul E. McKenney [this message]
2022-08-01 15:41           ` Will Deacon
2022-08-01 19:20             ` Paul E. McKenney
2022-08-02  8:54               ` Will Deacon
2022-08-02 13:49                 ` Paul E. McKenney
2022-08-02 15:29                   ` Paul E. McKenney
2022-07-31 20:39         ` Mikulas Patocka
2022-07-31 20:40           ` [PATCH v3 1/2] wait_bit: do read barrier after testing a bit Mikulas Patocka
2022-07-31 20:57             ` Linus Torvalds
2022-08-01 10:40               ` Mikulas Patocka
2022-08-01 10:43                 ` [PATCH v4 2/2] change buffer_locked, so that it has acquire semantics Mikulas Patocka
2022-08-01 14:37                   ` Matthew Wilcox
2022-08-01 15:01                     ` Mikulas Patocka
2022-08-05  3:22                       ` Matthew Wilcox
2022-08-07 11:37                         ` [PATCH v5] add barriers to buffer functions Mikulas Patocka
2022-08-07 14:50                           ` Matthew Wilcox
2022-08-08 14:26                             ` Mikulas Patocka
2022-08-08 14:40                               ` Matthew Wilcox
2022-08-08 14:57                                 ` Mikulas Patocka
2022-08-08 15:31                                   ` Paul E. McKenney
2022-08-08 15:39                                   ` Matthew Wilcox
2022-08-09 18:32                                     ` [PATCH v6] add barriers to buffer_uptodate and set_buffer_uptodate Mikulas Patocka
2022-08-09 19:44                                       ` Matthew Wilcox
2022-08-09 22:06                                       ` Linus Torvalds
2022-08-01 10:42               ` [PATCH v4 1/2] introduce test_bit_acquire and use it in wait_on_bit Mikulas Patocka
2022-08-01 15:54                 ` Will Deacon
2022-08-01 16:12                   ` Mikulas Patocka
2022-08-01 18:17                     ` Boqun Feng
2022-08-02  8:00                       ` David Laight
2022-08-02  8:40                     ` Will Deacon
2022-08-02 11:38                       ` Mikulas Patocka
2022-08-02 13:36                         ` Will Deacon
2022-08-02 15:57                           ` Mikulas Patocka
2022-08-01  0:27             ` [PATCH v3 1/2] wait_bit: do read barrier after testing a bit Alan Stern
2022-07-31 20:43           ` [PATCH v3 2/2] make buffer_locked provide an acquire semantics Mikulas Patocka
2022-07-31 20:51             ` Linus Torvalds
2022-07-31 22:14             ` Matthew Wilcox
2022-07-31 22:31               ` Ard Biesheuvel
2022-07-31 22:48                 ` Ard Biesheuvel
2022-07-31 20:46           ` [PATCH v2] " Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801032045.GZ2860372@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=akiyks@gmail.com \
    --cc=ardb@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=joel@joelfernandes.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=mpatocka@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=peterz@infradead.org \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®