mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: Johannes.Thumshirn@wdc.com, snitzer@kernel.org, axboe@kernel.dk,
	damien.lemoal@opensource.wdc.com, agk@redhat.com, hch@lst.de
Cc: dm-devel@redhat.com, matias.bjorling@wdc.com,
	gost.dev@samsung.com, linux-kernel@vger.kernel.org,
	pankydev8@gmail.com, jaegeuk@kernel.org, hare@suse.de,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	bvanassche@acm.org, Pankaj Raghav <p.raghav@samsung.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v9 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes
Date: Wed,  3 Aug 2022 11:47:52 +0200	[thread overview]
Message-ID: <20220803094801.177490-5-p.raghav@samsung.com> (raw)
In-Reply-To: <20220803094801.177490-1-p.raghav@samsung.com>

A generic bdev_zone_no() helper is added to calculate zone number for a
given sector in a block device. This helper internally uses disk_zone_no()
to find the zone number.

Use the helper bdev_zone_no() to calculate nr of zones. This let's us
make modifications to the math if needed in one place and adds now
support for zoned devices with non po2 zone size.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 drivers/nvme/target/zns.c | 3 +--
 include/linux/blkdev.h    | 5 +++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index c7ef69f29fe4..662f1a92f39b 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -241,8 +241,7 @@ static unsigned long nvmet_req_nr_zones_from_slba(struct nvmet_req *req)
 {
 	unsigned int sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba);
 
-	return bdev_nr_zones(req->ns->bdev) -
-		(sect >> ilog2(bdev_zone_sectors(req->ns->bdev)));
+	return bdev_nr_zones(req->ns->bdev) - bdev_zone_no(req->ns->bdev, sect);
 }
 
 static unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 bufsize)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 5aa15172299d..ead848a15946 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1345,6 +1345,11 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
 	return BLK_ZONED_NONE;
 }
 
+static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec)
+{
+	return disk_zone_no(bdev->bd_disk, sec);
+}
+
 static inline int queue_dma_alignment(const struct request_queue *q)
 {
 	return q ? q->dma_alignment : 511;
-- 
2.25.1


  parent reply	other threads:[~2022-08-03  9:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220803094802eucas1p2052b092c7bd82bea1a0ac4a5d70d7bc9@eucas1p2.samsung.com>
2022-08-03  9:47 ` [PATCH v9 00/13] support zoned block devices with non-power-of-2 " Pankaj Raghav
     [not found]   ` <CGME20220803094803eucas1p2ee8d16f3b6e08203ac9b4e0df6f53d9d@eucas1p2.samsung.com>
2022-08-03  9:47     ` [PATCH v9 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
     [not found]   ` <CGME20220803094804eucas1p1feea4b1bdae819f4c8750994ddd94803@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-03 17:11       ` [dm-devel] [PATCH v9 02/13] block:rearrange bdev_{is_zoned, zone_sectors, get_queue} " Bart Van Assche
2022-08-10 16:50       ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} " Damien Le Moal
     [not found]   ` <CGME20220803094805eucas1p1c68ba40d319331c2c34059f966ba2d83@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-08-03 17:18       ` [dm-devel] " Bart Van Assche
2022-08-10 17:03       ` Damien Le Moal
2022-08-11 13:13         ` Pankaj Raghav
     [not found]   ` <CGME20220803094806eucas1p24e1fd0f3a595e050d79c4315559d97ae@eucas1p2.samsung.com>
2022-08-03  9:47     ` Pankaj Raghav [this message]
2022-08-10 17:04       ` [PATCH v9 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Damien Le Moal
     [not found]   ` <CGME20220803094808eucas1p1a6a800161d32fe4242d39e669e5f3527@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-03 17:22       ` [dm-devel] " Bart Van Assche
2022-08-04  7:29         ` Pankaj Raghav
     [not found]   ` <CGME20220803094809eucas1p1e24ddc3076eaa05db0658b88fd34ffd4@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220803094810eucas1p1304a82ba94d0265c3f6a8a371e5127a7@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
     [not found]   ` <CGME20220803094811eucas1p17a2ac191899bba7938de6b9e3a55352f@eucas1p1.samsung.com>
2022-08-03  9:47     ` [PATCH v9 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-08-10 17:10       ` Damien Le Moal
     [not found]   ` <CGME20220803094812eucas1p271cea804453d9dd379b919067fe5b154@eucas1p2.samsung.com>
2022-08-03  9:47     ` [PATCH v9 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-08-03 17:23       ` Bart Van Assche
     [not found]   ` <CGME20220803094813eucas1p2eab78901e97417ad52be1f8023db3d82@eucas1p2.samsung.com>
2022-08-03  9:47     ` [PATCH v9 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-03 17:24       ` [dm-devel] " Bart Van Assche
2022-08-10 17:12       ` Damien Le Moal
     [not found]   ` <CGME20220803094814eucas1p2789149466d095cc16710ee09a380cbdb@eucas1p2.samsung.com>
2022-08-03  9:47     ` [PATCH v9 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
     [not found]   ` <CGME20220803094815eucas1p2dfab477daf4f2eb05342d756fdf7f14d@eucas1p2.samsung.com>
2022-08-03  9:48     ` [PATCH v9 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
2022-08-10 17:16       ` Damien Le Moal
     [not found]   ` <CGME20220803094816eucas1p1890ceb4faebaf4f0cdbc9581d1308672@eucas1p1.samsung.com>
2022-08-03  9:48     ` [PATCH v9 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-10 12:24       ` Joel Granados
2022-08-10 17:31       ` Damien Le Moal
2022-08-11 13:17         ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220803094801.177490-5-p.raghav@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=mcgrof@kernel.org \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®