From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA78CC25B06 for ; Thu, 4 Aug 2022 14:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240074AbiHDOz5 (ORCPT ); Thu, 4 Aug 2022 10:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239980AbiHDOzy (ORCPT ); Thu, 4 Aug 2022 10:55:54 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C5E61CB36; Thu, 4 Aug 2022 07:55:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 553BF5BD9F; Thu, 4 Aug 2022 14:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1659624951; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9vqM3B55556WrkSb/OXBXnK58c5Ih8NOpEHlhkqemA4=; b=rNHv8QiNy3c5z8yVJYDxDTuMZdudL77DDEKwQScGWzveekPm6K6d92Eigi3//1z18P+j6T RIBk2A9+Gbr/GaG2LQxCIKam5jar59qcEluUyW+jEfFYSJEX8asRo/4CPEA/glwkOL3smh GG2PYfSwMM3DbGo8ER53fwfpz2KVsng= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1659624951; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9vqM3B55556WrkSb/OXBXnK58c5Ih8NOpEHlhkqemA4=; b=qsfVFAylGeEqH5umlWB9oet2ZyR410Fy05HQBAnbpgYI4e03uyEiOpEcA7GMckUO5MF1So TftfKIPExmNcPRCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2244513A94; Thu, 4 Aug 2022 14:55:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vtRSB/fd62IaAwAAMHmgww (envelope-from ); Thu, 04 Aug 2022 14:55:51 +0000 Date: Thu, 4 Aug 2022 16:50:48 +0200 From: David Sterba To: Sweet Tea Dorminy Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Omar Sandoval Subject: Re: [PATCH] btrfs: change btrfs_insert_file_extent() to btrfs_insert_hole_extent() Message-ID: <20220804145048.GS13489@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Sweet Tea Dorminy , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Omar Sandoval References: <41e212570f521d9c0838b5ab8e66da0f942c7f46.1658615058.git.sweettea-kernel@dorminy.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41e212570f521d9c0838b5ab8e66da0f942c7f46.1658615058.git.sweettea-kernel@dorminy.me> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 23, 2022 at 06:25:29PM -0400, Sweet Tea Dorminy wrote: > From: Omar Sandoval > > btrfs_insert_file_extent() is only ever used to insert holes, so rename > it and remove the redundant parameters. > > Signed-off-by: Omar Sandoval > Signed-off-by: Sweet Tea Dorminy Added to misc-next, thanks. The patch is from long ago so there was probably intention to do more than just inserting hole but I don't remember any pending feature that would use the helper. If we need it it can be extended again.