From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38493C19F2D for ; Tue, 9 Aug 2022 20:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343544AbiHIUp1 (ORCPT ); Tue, 9 Aug 2022 16:45:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343714AbiHIUpW (ORCPT ); Tue, 9 Aug 2022 16:45:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B990360E5 for ; Tue, 9 Aug 2022 13:45:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A85060EE2 for ; Tue, 9 Aug 2022 20:45:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FB39C433C1; Tue, 9 Aug 2022 20:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660077917; bh=9KJdonOg4u1iSkkOzi21IONx6muGEp+9s546Vhnx15Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f0dw6ZFU6iW5hCI1Mou34KdaBR06Qk85oO0GD+xFfyP+dP8MNRN8avo4amp3GZ7EE gT2b+bDpw5gwz8zH3+D5m3kLgbDAm41VJLqax4TOBRYi4ZZQiaMWa8a/cN+atGSTrU usVeI7l7RZhenk5OakuJnlEToTfk8LLXpOVNmARWHRZ+iXNZW/1of5qug6hWYw+wyY +RKS1Y3U41SJIEaHQXOvcdKhe8b347NrSZtj49t4iSq7EQnbNkJJLMvjoAIAPJYgUx WfZwQr+4ESAK/1lNBjvamXU3eJOExTrce7bsvRQpOOYImPTakjM30VmBm4M1P3rqAs 1pYmP56JTNpoQ== Received: by pali.im (Postfix) id 9D6F4C1F; Tue, 9 Aug 2022 22:45:14 +0200 (CEST) Date: Tue, 9 Aug 2022 22:45:14 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Marek =?utf-8?B?QmVow7pu?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases Message-ID: <20220809204514.wu2om56mljsw4flz@pali> References: <20220727130926.1874-1-pali@kernel.org> <20220727131504.avbfyoydzgcf6wyo@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote: > On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote: > > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote: > > > This allows bootloader to correctly pass MAC addresses used by bootloader > > > to individual interfaces into kernel device tree. > > > > > > Signed-off-by: Pali Rohár > > > --- > > > > Maybe this should have Fixes line? > > > > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") > > Is it broken with older kernels? That is a big part of Fixes: to > indicate it needs back porting. Is this a new u-boot feature? > > Andrew This is old u-boot feature. I was investigating why u-boot is not able to correctly modify loaded omnia dtb file when booting linux kernel and I found out that it is because it cannot due to missing ethernet aliases. Also there is a new u-boot feature for omnia to correctly put phy-reset-gpios property into eth 2 node based on board hw revision. So this is another purpose for which we should have those aliases, to allow kernel to correctly reset wan (eth 2) PHY. I would suggest this change for backporting into stable.