From: Dongliang Mu <dzm91@hust.edu.cn>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dongliang Mu <mudongliangabcd@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] USB: ncevibrator: simplify tv_probe
Date: Thu, 11 Aug 2022 10:53:42 +0800 [thread overview]
Message-ID: <20220811025346.113199-2-dzm91@hust.edu.cn> (raw)
In-Reply-To: <20220811025346.113199-1-dzm91@hust.edu.cn>
From: Dongliang Mu <mudongliangabcd@gmail.com>
The function tv_probe does not need to invoke kfree when the
allocation fails. So let's simplify the code of tv_probe.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/usb/misc/trancevibrator.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c
index 55cb63652eda..30d4d774d448 100644
--- a/drivers/usb/misc/trancevibrator.c
+++ b/drivers/usb/misc/trancevibrator.c
@@ -84,22 +84,15 @@ static int tv_probe(struct usb_interface *interface,
{
struct usb_device *udev = interface_to_usbdev(interface);
struct trancevibrator *dev;
- int retval;
dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
- if (!dev) {
- retval = -ENOMEM;
- goto error;
- }
+ if (!dev)
+ return -ENOMEM;
dev->udev = usb_get_dev(udev);
usb_set_intfdata(interface, dev);
return 0;
-
-error:
- kfree(dev);
- return retval;
}
static void tv_disconnect(struct usb_interface *interface)
--
2.35.1
next prev parent reply other threads:[~2022-08-11 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 2:53 [PATCH 1/2] USB: trancevibrator: remove redundant space Dongliang Mu
2022-08-11 2:53 ` Dongliang Mu [this message]
2022-08-11 8:34 ` [PATCH 2/2] USB: ncevibrator: simplify tv_probe Sergey Shtylyov
2022-08-11 8:57 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811025346.113199-2-dzm91@hust.edu.cn \
--to=dzm91@hust.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®