mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Richard Weinberger <richard@nod.at>,
	Sasha Levin <sashal@kernel.org>,
	anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net,
	linux@roeck-us.net, linux-um@lists.infradead.org
Subject: [PATCH AUTOSEL 5.18 38/56] um: add "noreboot" command line option for PANIC_TIMEOUT=-1 setups
Date: Sun, 14 Aug 2022 11:30:08 -0400	[thread overview]
Message-ID: <20220814153026.2377377-38-sashal@kernel.org> (raw)
In-Reply-To: <20220814153026.2377377-1-sashal@kernel.org>

From: "Jason A. Donenfeld" <Jason@zx2c4.com>

[ Upstream commit dda520d07b95072a0b63f6c52a8eb566d08ea897 ]

QEMU has a -no-reboot option, which halts instead of reboots when the
guest asks to reboot. This is invaluable when used with
CONFIG_PANIC_TIMEOUT=-1 (and panic_on_warn), because it allows panics
and warnings to be caught immediately in CI. Implement this in UML too,
by way of a basic setup param.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/um/os-Linux/skas/process.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c
index 87d3129e7362..0df2ebcc97c0 100644
--- a/arch/um/os-Linux/skas/process.c
+++ b/arch/um/os-Linux/skas/process.c
@@ -5,6 +5,7 @@
  */
 
 #include <stdlib.h>
+#include <stdbool.h>
 #include <unistd.h>
 #include <sched.h>
 #include <errno.h>
@@ -707,10 +708,24 @@ void halt_skas(void)
 	UML_LONGJMP(&initial_jmpbuf, INIT_JMP_HALT);
 }
 
+static bool noreboot;
+
+static int __init noreboot_cmd_param(char *str, int *add)
+{
+	noreboot = true;
+	return 0;
+}
+
+__uml_setup("noreboot", noreboot_cmd_param,
+"noreboot\n"
+"    Rather than rebooting, exit always, akin to QEMU's -no-reboot option.\n"
+"    This is useful if you're using CONFIG_PANIC_TIMEOUT in order to catch\n"
+"    crashes in CI\n");
+
 void reboot_skas(void)
 {
 	block_signals_trace();
-	UML_LONGJMP(&initial_jmpbuf, INIT_JMP_REBOOT);
+	UML_LONGJMP(&initial_jmpbuf, noreboot ? INIT_JMP_HALT : INIT_JMP_REBOOT);
 }
 
 void __switch_mm(struct mm_id *mm_idp)
-- 
2.35.1


  parent reply	other threads:[~2022-08-14 15:39 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 15:29 [PATCH AUTOSEL 5.18 01/56] thunderbolt: Change downstream router's TMU rate in both TMU uni/bidir mode Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 02/56] HID: multitouch: new device class fix Lenovo X12 trackpad sticky Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 03/56] PCI: Add ACS quirk for Broadcom BCM5750x NICs Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 04/56] platform/chrome: cros_ec_proto: don't show MKBP version if unsupported Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 05/56] usb: cdns3 fix use-after-free at workaround 2 Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 06/56] usb: cdns3: fix random warning message when driver load Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 07/56] usb: gadget: uvc: calculate the number of request depending on framesize Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 08/56] usb: gadget: uvc: call uvc uvcg_warn on completed status instead of uvcg_info Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 09/56] PCI: aardvark: Fix reporting Slot capabilities on emulated bridge Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 10/56] scsi: ufs: core: Add UFSHCD_QUIRK_BROKEN_64BIT_ADDRESS Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 11/56] scsi: ufs: core: Add UFSHCD_QUIRK_HIBERN_FASTAUTO Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 12/56] irqchip/tegra: Fix overflow implicit truncation warnings Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 13/56] drm/meson: " Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 14/56] clk: ti: Stop using legacy clkctrl names for omap4 and 5 Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 15/56] scsi: ufs: ufs-mediatek: Fix the timing of configuring device regulators Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 16/56] usb: host: ohci-ppc-of: Fix refcount leak bug Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 17/56] usb: renesas: " Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 18/56] scsi: iscsi: Fix HW conn removal use after free Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 19/56] usb: dwc2: gadget: remove D+ pull-up while no vbus with usb-role-switch Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 20/56] vboxguest: Do not use devm for irq Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 21/56] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 22/56] uacce: Handle parent device removal or parent driver module rmmod Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 23/56] zram: do not lookup algorithm in backends table Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 24/56] clk: qcom: clk-alpha-pll: fix clk_trion_pll_configure description Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 25/56] scsi: lpfc: Prevent buffer overflow crashes in debugfs with malformed user input Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 26/56] scsi: lpfc: Fix possible memory leak when failing to issue CMF WQE Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 27/56] gadgetfs: ep_io - wait until IRQ finishes Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 28/56] coresight: etm4x: avoid build failure with unrolled loops Sasha Levin
2022-08-14 15:29 ` [PATCH AUTOSEL 5.18 29/56] habanalabs: add terminating NULL to attrs arrays Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 30/56] habanalabs/gaudi: invoke device reset from one code block Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 31/56] habanalabs/gaudi: fix shift out of bounds Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 32/56] habanalabs/gaudi: mask constant value before cast Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 33/56] mmc: tmio: avoid glitches when resetting Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 34/56] scsi: ufs: ufs-exynos: Change ufs phy control sequence Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 35/56] pinctrl: intel: Check against matching data instead of ACPI companion Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 36/56] cxl: Fix a memory leak in an error handling path Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 37/56] PCI/ACPI: Guard ARM64-specific mcfg_quirks Sasha Levin
2022-08-14 15:30 ` Sasha Levin [this message]
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 39/56] dmaengine: dw-axi-dmac: do not print NULL LLI during error Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 40/56] dmaengine: dw-axi-dmac: ignore interrupt if no descriptor Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 41/56] ACPI: PPTT: Leave the table mapped for the runtime usage Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 42/56] RDMA/rxe: Limit the number of calls to each tasklet Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 43/56] csky/kprobe: reclaim insn_slot on kprobe unregistration Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 44/56] selftests/kprobe: Do not test for GRP/ without event failures Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 45/56] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 46/56] ARM: 9202/1: kasan: support CONFIG_KASAN_VMALLOC Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 47/56] ARM: 9203/1: kconfig: fix MODULE_PLTS for KASAN with KASAN_VMALLOC Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 48/56] openrisc: io: Define iounmap argument as volatile Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 49/56] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 50/56] md: Notify sysfs sync_completed in md_reap_sync_thread() Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 51/56] md/raid5: Make logic blocking check consistent with logic that blocks Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 52/56] nvmet-tcp: fix lockdep complaint on nvmet_tcp_wq flush during queue teardown Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 53/56] drivers:md:fix a potential use-after-free bug Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 54/56] ext4: avoid remove directory when directory is corrupted Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 55/56] ext4: block range must be validated before use in ext4_mb_clear_bb() Sasha Levin
2022-08-14 15:30 ` [PATCH AUTOSEL 5.18 56/56] ext4: avoid resizing to a partial cluster size Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220814153026.2377377-38-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®