From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00880C00140 for ; Tue, 16 Aug 2022 02:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234310AbiHPCBn (ORCPT ); Mon, 15 Aug 2022 22:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243792AbiHPCBO (ORCPT ); Mon, 15 Aug 2022 22:01:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 960CE22004E for ; Mon, 15 Aug 2022 14:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660600403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=nE9l+oBuuihtRdwrfLYvB+ZfpLg2bb3PcW4cPmCNwqE=; b=e7ujuefvU4TMWR2hDcXTN4ooTSAvNLK61ZYJP+7Vu+GhBtFgUWXFy9y0nkzGTt0QLO+hgb tR8u/+nclntTEJgfWY57hVvwqVx9nod/27J/QBRfXXLUBX6bNjyDxPHfeR4ZQzWg72/uoF PUsoY7VyFydSjmuUy5Gv0xeKwmAAqoQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-645-jeuOEB6IP3Ggkh_d40yIGQ-1; Mon, 15 Aug 2022 17:53:21 -0400 X-MC-Unique: jeuOEB6IP3Ggkh_d40yIGQ-1 Received: by mail-wm1-f71.google.com with SMTP id r4-20020a1c4404000000b003a5fa79008bso305556wma.5 for ; Mon, 15 Aug 2022 14:53:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=nE9l+oBuuihtRdwrfLYvB+ZfpLg2bb3PcW4cPmCNwqE=; b=Kfszxr7iatxAO9iFO4Jr8jeGGmCalXfwF7xpDbalRKZq7WB5lm0jiqqJ7lUF5CxzTa LAEP9OUr231vXApKkBCZ3Um9qyfzvFm71HmOiRorGYN5LMNFC2KgqZqaQZxtYFg1Vczh qWz+9uzaozAlaj19RX1ehyuVnlFvJipx1wyy6G3OTVCOubXl/TA5klB2YB1w/wXF+4TE ZDhSJGYwU12eRy652uNuUUNJdwVvY6x+0JTKcPAnoyT8xJ/Zv32WOonGjzW2I6M6VpMO LHR6h+HpZPEQ47J0tkgMKAGRaKB5TYNpQg6IziA4OSwJ+m6+dsWEXXedZPEjtz97pTqJ nUZw== X-Gm-Message-State: ACgBeo3UhIDDpt1TA8aeQY1fjTnFKiqUPsyCSDMQZON+M2ttaEAe8bwc GPOeO+dgQHJeDDa7wgIANzjhd1aB8NOrvSwyaxK0reQroS0BfO6k8q7rkuTgJgKf7q/d0vTV9ZV tbAx637VT139P+OJZGF3Ubwm5jyEeztonP9535v+oll6shh48gNx9pJ28wA7NdWb6/VgZ+Q== X-Received: by 2002:adf:e588:0:b0:21f:ace:dd82 with SMTP id l8-20020adfe588000000b0021f0acedd82mr9691344wrm.226.1660600400394; Mon, 15 Aug 2022 14:53:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR4hxSDMZpftCBBMFSFs4qXARqcIDfoNeMwyu98fDGaG6R9gCUSZWy72wuRpnU0bbvDp4w56Vw== X-Received: by 2002:adf:e588:0:b0:21f:ace:dd82 with SMTP id l8-20020adfe588000000b0021f0acedd82mr9691323wrm.226.1660600400097; Mon, 15 Aug 2022 14:53:20 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id j27-20020a05600c1c1b00b003a32251c3f9sm11520530wms.5.2022.08.15.14.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 14:53:19 -0700 (PDT) Date: Mon, 15 Aug 2022 17:53:14 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Xuan Zhuo , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Linus Torvalds , Jens Axboe , James Bottomley , "Martin K. Petersen" , Guenter Roeck , Greg KH Subject: [PATCH v2 0/5] virtio: drop sizing vqs during init Message-ID: <20220815215251.154451-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Supplying size during init does not work for all transports. In fact for legacy pci doing that causes a memory corruption which was reported on Google Cloud. We might get away with changing size to size_hint so it's safe to ignore and then fixing legacy to ignore the hint. But the benefit is unclear in any case, so let's revert for now. Any new version will have to come with - documentation of performance gains - performance testing showing existing workflows are not harmed materially. especially ones with bursty traffic - report of testing on legacy devices Huge shout out to Andres Freund for the effort spent reproducing and debugging! Thanks to Guenter Roeck for help with testing! Michael S. Tsirkin (5): virtio_net: Revert "virtio_net: set the default max ring size by find_vqs()" virtio: Revert "virtio: add helper virtio_find_vqs_ctx_size()" virtio-mmio: Revert "virtio_mmio: support the arg sizes of find_vqs()" virtio_pci: Revert "virtio_pci: support the arg sizes of find_vqs()" virtio: Revert "virtio: find_vqs() add arg sizes" arch/um/drivers/virtio_uml.c | 2 +- drivers/net/virtio_net.c | 42 +++--------------------- drivers/platform/mellanox/mlxbf-tmfifo.c | 1 - drivers/remoteproc/remoteproc_virtio.c | 1 - drivers/s390/virtio/virtio_ccw.c | 1 - drivers/virtio/virtio_mmio.c | 9 ++--- drivers/virtio/virtio_pci_common.c | 20 +++++------ drivers/virtio/virtio_pci_common.h | 3 +- drivers/virtio/virtio_pci_legacy.c | 6 +--- drivers/virtio/virtio_pci_modern.c | 17 +++------- drivers/virtio/virtio_vdpa.c | 1 - include/linux/virtio_config.h | 26 +++------------ 12 files changed, 28 insertions(+), 101 deletions(-) -- MST