From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+744e173caec2e1627ee0@syzkaller.appspotmail.com,
Oliver Upton <oliver.upton@linux.dev>,
Sean Christopherson <seanjc@google.com>,
David Matlack <dmatlack@google.com>
Subject: [PATCH 0/3] KVM: kvm_create_vm() bug fixes and cleanup
Date: Tue, 16 Aug 2022 05:39:34 +0000 [thread overview]
Message-ID: <20220816053937.2477106-1-seanjc@google.com> (raw)
Fix two (embarassing) bugs in kvm_create_vm() where KVM fails to properly
unwind VM creation, which most often manifests as a not-present page fault
due to use-after-free when walking the global vm_list (VM is added and
freed, but never removed from the list). Patch 3 is a loosely related
clean up.
I discovered the try_get_module() bug by inspection[*]. syzkaller found
the debugfs around the same time.
The try_get_module() bug is especially bad/amusing. The "rmmod --wait"
behavior KVM is trying to handle was removed ~9 years ago...
[*] https://lore.kernel.org/all/YvU+6fdkHaqQiKxp@google.com
Sean Christopherson (3):
KVM: Properly unwind VM creation if creating debugfs fails
KVM: Unconditionally get a ref to /dev/kvm module when creating a VM
KVM: Move coalesced MMIO initialization (back) into kvm_create_vm()
virt/kvm/kvm_main.c | 39 +++++++++++++++++----------------------
1 file changed, 17 insertions(+), 22 deletions(-)
base-commit: 19a7cc817a380f7a412d7d76e145e9e2bc47e52f
--
2.37.1.595.g718a3a8f04-goog
next reply other threads:[~2022-08-16 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 5:39 Sean Christopherson [this message]
2022-08-16 5:39 ` [PATCH 1/3] KVM: Properly unwind VM creation if creating debugfs fails Sean Christopherson
2022-08-16 17:52 ` Oliver Upton
2022-08-16 5:39 ` [PATCH 2/3] KVM: Unconditionally get a ref to /dev/kvm module when creating a VM Sean Christopherson
2022-08-16 17:01 ` David Matlack
2022-08-16 21:43 ` Sean Christopherson
2022-08-16 5:39 ` [PATCH 3/3] KVM: Move coalesced MMIO initialization (back) into kvm_create_vm() Sean Christopherson
2022-08-16 18:04 ` Oliver Upton
2022-08-16 19:23 ` Sean Christopherson
2022-08-17 9:47 ` [PATCH 0/3] KVM: kvm_create_vm() bug fixes and cleanup Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816053937.2477106-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=syzbot+744e173caec2e1627ee0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®