From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10FBC25B0E for ; Tue, 16 Aug 2022 12:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235499AbiHPMOC (ORCPT ); Tue, 16 Aug 2022 08:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235411AbiHPMNc (ORCPT ); Tue, 16 Aug 2022 08:13:32 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B598253D00; Tue, 16 Aug 2022 05:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1660651740; x=1692187740; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Tn/qQFYz5KIe5ySlji7fQeK6RfhXsdNtBpQADNtHANI=; b=Wz9fFwtIzmubwEvc1PPCpenQYi8AOhlTscnB9/F8DxlJsbTO37B3XMCu wRj5WjF89yvL0MXs2JuZsjaiigB1TE4yLv8UPKQNzcYXyFCCtXnZ8Cry4 59gih8cuuyZs6YBkrGSLikN3cbYn/kQk72B4dpLhJ1FCTWZqvQt8k+9NX qUayi1w15F/pEEitzjATer/gkjvlo2ZK7y9GFQ2IBdtdvWF9AWnfCGc7Y xe5uJYW8yiJQHlAV9RJ0XxFUZ1cPyQsFzkEwGc3FxZJAt4ZW2BWg26UEs ZDNaUaelXtVMiQHAi37A/TAicMfzvVJElBB4jRZGbP/0IyNjNZ1lm9vBE Q==; X-IronPort-AV: E=Sophos;i="5.93,241,1654585200"; d="scan'208";a="169493744" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Aug 2022 05:08:59 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 16 Aug 2022 05:08:58 -0700 Received: from wendy.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Tue, 16 Aug 2022 05:08:56 -0700 From: Conor Dooley To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , "Rob Herring" , Krzysztof Kozlowski CC: Daire McNamara , , , , , Conor Dooley Subject: [PATCH v8 0/4] Microchip soft ip corePWM driver Date: Tue, 16 Aug 2022 13:08:26 +0100 Message-ID: <20220816120829.719749-1-conor.dooley@microchip.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Uwe, all, 6.0-rc1 has rolled around so here is the promised v8. The prior cover letter/series is here: https://lore.kernel.org/linux-pwm/20220721172109.941900-1-mail@conchuod.ie I'll take the dts change myself once the rest is merged. There is one change here that is not directly from your feedback, I added a test for invalid PERIOD_STEPS values, in which case we abort if the period is locked and cannot be fixed. Hopefully the rounding is not ruined.. Thanks, Conor. Changes since v7: - rebased on 6.0-rc1 - reworded comments you highlighted in v7 - fixed the overkill sleeping - removed the unused variables in calc_duty - added some extra comments to explain behaviours you questioned in v7 - make the mutexes un-interruptible - fixed added the 1s you suggested for the if(period_locked) logic - added setup of the channel_enabled shadowing - fixed the period reporting for the negedge == posedge case in get_state() I had to add the enabled check, as otherwise it broke setting the period for the first time out of reset. - added a test for invalid PERIOD_STEPS values, in which case we abort if we cannot fix the period Changes from v6: - Dropped an unused variable that I'd missed - Actually check the return values of the mutex lock()s - Re-rebased on -next for the MAINTAINERS patch (again...) Changes from v5: - switched to a mutex b/c we must sleep with the lock taken - simplified the locking in apply() and added locking to get_state() - reworked apply() as requested - removed the loop in the period calculation (thanks Uwe!) - add a copy of the enable registers in the driver to save on reads. - remove the second (useless) write to sync_update - added some missing rounding in get_state() - couple other minor cleanups as requested in: https://lore.kernel.org/linux-riscv/20220709160206.cw5luo7kxdshoiua@pengutronix.de/ Changes from v4: - dropped some accidentally added files Conor Dooley (4): dt-bindings: pwm: fix microchip corePWM's pwm-cells riscv: dts: fix the icicle's #pwm-cells pwm: add microchip soft ip corePWM driver MAINTAINERS: add pwm to PolarFire SoC entry .../bindings/pwm/microchip,corepwm.yaml | 4 +- MAINTAINERS | 1 + .../dts/microchip/mpfs-icicle-kit-fabric.dtsi | 2 +- drivers/pwm/Kconfig | 10 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-microchip-core.c | 396 ++++++++++++++++++ 6 files changed, 412 insertions(+), 2 deletions(-) create mode 100644 drivers/pwm/pwm-microchip-core.c -- 2.36.1