From: Guenter Roeck <linux@roeck-us.net>
To: Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/watchdog: fix repeated words in comments
Date: Tue, 16 Aug 2022 08:50:59 -0700 [thread overview]
Message-ID: <20220816155059.GA3310237@roeck-us.net> (raw)
In-Reply-To: <20220816124126.14298-1-yuanjilin@cdjrlc.com>
On Tue, Aug 16, 2022 at 08:41:26PM +0800, Jilin Yuan wrote:
> Delete the redundant word 'we'.
> Delete the redundant word 'set'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
I am going to ignore all those patches simply because the subject does
not mention the affected driver (but does mention the unnecessary
"drivers"). Really, and I have said that before, if you really have
to submit those cosmetic patches, at least do it right.
Guenter
> ---
> drivers/watchdog/wdt_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
> index d5e56b601351..a5fed7ea0243 100644
> --- a/drivers/watchdog/wdt_pci.c
> +++ b/drivers/watchdog/wdt_pci.c
> @@ -347,7 +347,7 @@ static irqreturn_t wdtpci_interrupt(int irq, void *dev_id)
> * @ppos: pointer to the position to write. No seeks allowed
> *
> * A write to a watchdog device is defined as a keepalive signal. Any
> - * write of data will do, as we we don't define content meaning.
> + * write of data will do, as we don't define content meaning.
> */
>
> static ssize_t wdtpci_write(struct file *file, const char __user *buf,
> @@ -443,7 +443,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
> * open and on opening we load the counters. Counter zero is a 100Hz
> * cascade, into counter 1 which downcounts to reboot. When the counter
> * triggers counter 2 downcounts the length of the reset pulse which
> - * set set to be as long as possible.
> + * set to be as long as possible.
> */
>
> static int wdtpci_open(struct inode *inode, struct file *file)
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-08-16 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 12:41 Jilin Yuan
2022-08-16 15:50 ` Guenter Roeck [this message]
2022-08-16 12:42 Jilin Yuan
2022-08-16 12:43 Jilin Yuan
2022-08-16 12:44 Jilin Yuan
2022-08-16 12:45 Jilin Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816155059.GA3310237@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®