From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96449C32772 for ; Wed, 17 Aug 2022 09:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233769AbiHQJak (ORCPT ); Wed, 17 Aug 2022 05:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbiHQJac (ORCPT ); Wed, 17 Aug 2022 05:30:32 -0400 Received: from mail.pr-group.ru (mail.pr-group.ru [178.18.215.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92DDA5A824; Wed, 17 Aug 2022 02:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to: references; bh=B1hmJLzhgp+cCdKeDExeQqbkP18e8HhH601vV+E1w50=; b=SXOXeg0hXtXaVqOOnK5acOIEm8TnPQJxV5wFYx4mSwxEoLkg1SF2ceF0q4XC8E52IuKOWgzTwwff8 GXTaypsIplyq9skK2OOme1XHNtGh9+gJV1UxKQo+3L9t/Lq2uSIJLBY49eqtcriHlkoZcEdBjbmWcu ywLD1UhtAxKNTjM5C7gkkbThg2UK/T8Z71T8oQSFrNdtfzLNoEmDJ37EJi3KeANAfYrg2aGL0OGeog +scBNcI0UVRdRncwg6FI0JZ2Z3VSWAp7+nvaDALG5h11YNccmhAErBJ6Vrn28g1/gAZE9wBWO8P2/2 uxcrEJA9EVm5WQYjGWz8OK2aq8vhlOA== X-Kerio-Anti-Spam: Build: [Engines: 2.16.3.1424, Stamp: 3], Multi: [Enabled, t: (0.000014,0.007457)], BW: [Enabled, t: (0.000014,0.000001)], RTDA: [Enabled, t: (0.074159), Hit: No, Details: v2.41.0; Id: 15.52kaaj.1gali6mdc.ev6o; mclb], total: 0(700) X-Footer: bWV0cm90ZWsucnU= Received: from x260 ([92.100.85.134]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Wed, 17 Aug 2022 12:29:55 +0300 Date: Wed, 17 Aug 2022 12:04:13 +0300 From: Ivan Bornyakov To: Xu Yilun Cc: mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, dg@emlix.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, system@metrotek.ru Subject: Re: [PATCH v6 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager Message-ID: <20220817090413.ywf7wescwj2manif@x260> References: <20220815132157.8083-1-i.bornyakov@metrotek.ru> <20220815132157.8083-2-i.bornyakov@metrotek.ru> <20220816045841.irhr5vigemdqknaw@x260> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 02:09:18PM +0800, Xu Yilun wrote: > On 2022-08-16 at 07:58:41 +0300, Ivan Bornyakov wrote: > > On Tue, Aug 16, 2022 at 10:00:41AM +0800, Xu Yilun wrote: > > > On 2022-08-15 at 16:21:56 +0300, Ivan Bornyakov wrote: > > > > Add support to the FPGA manager for programming Lattice ECP5 FPGA over > > > > slave SPI interface with .bit formatted uncompressed bitstream image. > > > > > > Not sure if something is missed. > > > > > > https://lore.kernel.org/all/20220729145757.GA2601292@yilunxu-OptiPlex-7050/ > > > > > > I was considering if a generic driver for lattice slave SPI sysCONFIG > > > interface could be introduced. From machxo2 & ecp5 Programming Usage > > > Guide, or others in this series, they basically use the same reconfigure > > > interface & protocol. > > > > > > Thanks, > > > Yilun > > > > > > > I only have HW with ECP5, can't vouch for the rest. > > I understand your concern, but having separate drivers for the same IP on > different boards makes the maintaining harder. > > We don't have to make everything fine, but start with machxo2 and ecp5 > first. If the change affects machxo2, other people may help. > > Thanks, > Yilun > Hi, Yilun. To clear things out, considering what Daniel said in https://lore.kernel.org/linux-fpga/20220816074216.GA31706@homes.emlix.com/ you still don't want separate ECP5 driver, or this v6 is OK and review continues?