From: Steven Rostedt <rostedt@goodmis.org>
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, David Reaver <me@davidreaver.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] tracing/perf: Fix double put of trace event when init fails
Date: Wed, 17 Aug 2022 10:03:31 -0400 [thread overview]
Message-ID: <20220817100331.0851f7a2@gandalf.local.home> (raw)
In-Reply-To: <20220817044656.GA1941@templeofstupid.com>
On Tue, 16 Aug 2022 21:46:56 -0700
Krister Johansen <kjlx@templeofstupid.com> wrote:
> Thanks again, Steven. Is this one that you would consider tagging for a
> backport to stable at the appropriate time? I believe this one showed up
> in 5.15, if it's any help.
So the warning started with this commit:
1d18538e6a092 ("tracing: Have dynamic events have a ref counter")
Which switched the module_put() to the trace_event_put(). I guess the
difference is that module_put() has
ret = atomic_dec_if_positive(&module->refcnt);
Where it could be called more than once after reaching zero and not warn
about it. But the trace_event_put() will warn if you call it after it
reaches zero.
I'll add a stable tag.
-- Steve
next prev parent reply other threads:[~2022-08-17 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 23:28 Steven Rostedt
2022-08-17 4:46 ` Krister Johansen
2022-08-17 14:03 ` Steven Rostedt [this message]
2022-08-17 9:16 ` Jiri Olsa
2022-08-17 14:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817100331.0851f7a2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®