Hi Chen, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on clk/clk-next linus/master v6.0-rc1 next-20220816] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chen-Zhongjin/x86-unwind-orc-Add-unwind_debug-cmdline-option/20220815-190328 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a1a5482a2c6e38a3ebed32e571625c56a8cc41a6 config: x86_64-randconfig-a012-20220815 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3295e738f5b51f1f1f223bf52a8ecee2ab93fbca git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Chen-Zhongjin/x86-unwind-orc-Add-unwind_debug-cmdline-option/20220815-190328 git checkout 3295e738f5b51f1f1f223bf52a8ecee2ab93fbca # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> arch/x86/kernel/unwind_orc.c:17:2: error: expected identifier or '(' if (state->task == current && !state->error) \ ^ arch/x86/kernel/unwind_orc.c:19:3: error: expected identifier or '(' if (unwind_debug && !dumped_before) \ ^ >> arch/x86/kernel/unwind_orc.c:21:3: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] dumped_before = true; \ ^ int >> arch/x86/kernel/unwind_orc.c:22:2: error: extraneous closing brace ('}') } \ ^ arch/x86/kernel/unwind_orc.c:22:11: error: extraneous closing brace ('}') } \ ^ arch/x86/kernel/unwind_orc.c:23:2: error: expected identifier or '(' }) ^ >> arch/x86/kernel/unwind_orc.c:219:21: error: use of undeclared identifier '__start_orc_unwind_ip' return __orc_find(__start_orc_unwind_ip + start, ^ arch/x86/kernel/unwind_orc.c:225:21: error: use of undeclared identifier '__start_orc_unwind_ip' return __orc_find(__start_orc_unwind_ip, __start_orc_unwind, ^ arch/x86/kernel/unwind_orc.c:226:30: error: use of undeclared identifier '__start_orc_unwind_ip' __stop_orc_unwind_ip - __start_orc_unwind_ip, ip); ^ arch/x86/kernel/unwind_orc.c:239:32: error: use of undeclared identifier '__start_orc_unwind_ip' static int *cur_orc_ip_table = __start_orc_unwind_ip; ^ arch/x86/kernel/unwind_orc.c:314:62: error: use of undeclared identifier '__start_orc_unwind_ip' size_t orc_ip_size = (void *)__stop_orc_unwind_ip - (void *)__start_orc_unwind_ip; ^ arch/x86/kernel/unwind_orc.c:336:20: error: use of undeclared identifier '__start_orc_unwind_ip' orc = __orc_find(__start_orc_unwind_ip, __start_orc_unwind, ^ arch/x86/kernel/unwind_orc.c:348:19: error: use of undeclared identifier '__start_orc_unwind_ip' orc = __orc_find(__start_orc_unwind_ip, __start_orc_unwind, num_entries, ^ arch/x86/kernel/unwind_orc.c:531:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("missing R10 value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ >> arch/x86/kernel/unwind_orc.c:535:3: error: expected ')' break; ^ arch/x86/kernel/unwind_orc.c:531:4: note: to match this '(' orc_warn_current("missing R10 value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:539:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("missing R13 value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ arch/x86/kernel/unwind_orc.c:543:3: error: expected ')' break; ^ arch/x86/kernel/unwind_orc.c:539:4: note: to match this '(' orc_warn_current("missing R13 value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:547:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("missing RDI value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ arch/x86/kernel/unwind_orc.c:551:3: error: expected ')' break; ^ arch/x86/kernel/unwind_orc.c:547:4: note: to match this '(' orc_warn_current("missing RDI value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:555:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("missing DX value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ arch/x86/kernel/unwind_orc.c:559:3: error: expected ')' break; ^ arch/x86/kernel/unwind_orc.c:555:4: note: to match this '(' orc_warn_current("missing DX value at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:593:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("can't access registers at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ arch/x86/kernel/unwind_orc.c:607:3: error: expected ')' state->ip = unwind_recover_rethook(state, state->ip, ^ arch/x86/kernel/unwind_orc.c:593:4: note: to match this '(' orc_warn_current("can't access registers at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:617:4: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("can't access iret registers at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ arch/x86/kernel/unwind_orc.c:622:3: error: expected ')' state->ip = unwind_recover_rethook(state, state->ip, ^ arch/x86/kernel/unwind_orc.c:617:4: note: to match this '(' orc_warn_current("can't access iret registers at %pB\n", ^ arch/x86/kernel/unwind_orc.c:14:39: note: expanded from macro 'orc_warn_current' #define orc_warn_current(args...) \ ^ arch/x86/kernel/unwind_orc.c:665:3: warning: unused variable 'dumped_before' [-Wunused-variable] orc_warn_current("stack going in the wrong direction? at %pB\n", ^ arch/x86/kernel/unwind_orc.c:16:14: note: expanded from macro 'orc_warn_current' static bool dumped_before; ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 7 warnings and 20 errors generated. vim +17 arch/x86/kernel/unwind_orc.c ee9f8fce996408 Josh Poimboeuf 2017-07-24 10 ee9f8fce996408 Josh Poimboeuf 2017-07-24 11 #define orc_warn(fmt, ...) \ b08418b5483125 Josh Poimboeuf 2020-04-25 12 printk_deferred_once(KERN_WARNING "WARNING: " fmt, ##__VA_ARGS__) b08418b5483125 Josh Poimboeuf 2020-04-25 13 b08418b5483125 Josh Poimboeuf 2020-04-25 14 #define orc_warn_current(args...) \ b08418b5483125 Josh Poimboeuf 2020-04-25 15 ({ \ 3295e738f5b51f Josh Poimboeuf 2022-08-15 16 static bool dumped_before; b59cc97674c947 Josh Poimboeuf 2021-02-05 @17 if (state->task == current && !state->error) \ b08418b5483125 Josh Poimboeuf 2020-04-25 18 orc_warn(args); \ 3295e738f5b51f Josh Poimboeuf 2022-08-15 19 if (unwind_debug && !dumped_before) \ 3295e738f5b51f Josh Poimboeuf 2022-08-15 20 unwind_dump(state); \ 3295e738f5b51f Josh Poimboeuf 2022-08-15 @21 dumped_before = true; \ 3295e738f5b51f Josh Poimboeuf 2022-08-15 @22 } \ b08418b5483125 Josh Poimboeuf 2020-04-25 23 }) ee9f8fce996408 Josh Poimboeuf 2017-07-24 24 -- 0-DAY CI Kernel Test Service https://01.org/lkp