From: Jan Kara <jack@suse.cz>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: jack@suse.cz, axboe@kernel.dk, paolo.valente@linaro.org,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH -next 1/3] block, bfq: remove unused functions
Date: Wed, 17 Aug 2022 13:55:01 +0200 [thread overview]
Message-ID: <20220817115501.bwfpvdgppwd4p55y@quack3> (raw)
In-Reply-To: <20220816015631.1323948-2-yukuai1@huaweicloud.com>
On Tue 16-08-22 09:56:29, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> While doing code coverage testing(CONFIG_BFQ_CGROUP_DEBUG is disabled), we
> found that some functions doesn't have caller, thus remove them.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bfq-cgroup.c | 5 -----
> block/bfq-iosched.h | 13 ++++++++-----
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 30b15a9a47c4..144bca006463 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -254,17 +254,12 @@ void bfqg_stats_update_completion(struct bfq_group *bfqg, u64 start_time_ns,
>
> #else /* CONFIG_BFQ_CGROUP_DEBUG */
>
> -void bfqg_stats_update_io_add(struct bfq_group *bfqg, struct bfq_queue *bfqq,
> - blk_opf_t opf) { }
> void bfqg_stats_update_io_remove(struct bfq_group *bfqg, blk_opf_t opf) { }
> void bfqg_stats_update_io_merged(struct bfq_group *bfqg, blk_opf_t opf) { }
> void bfqg_stats_update_completion(struct bfq_group *bfqg, u64 start_time_ns,
> u64 io_start_time_ns, blk_opf_t opf) { }
> void bfqg_stats_update_dequeue(struct bfq_group *bfqg) { }
> -void bfqg_stats_set_start_empty_time(struct bfq_group *bfqg) { }
> -void bfqg_stats_update_idle_time(struct bfq_group *bfqg) { }
> void bfqg_stats_set_start_idle_time(struct bfq_group *bfqg) { }
> -void bfqg_stats_update_avg_queue_size(struct bfq_group *bfqg) { }
>
> #endif /* CONFIG_BFQ_CGROUP_DEBUG */
>
> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index ad8e513d7e87..f81ab3c8fa3c 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -993,20 +993,23 @@ void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg);
> /* ---------------- cgroups-support interface ---------------- */
>
> void bfqg_stats_update_legacy_io(struct request_queue *q, struct request *rq);
> -void bfqg_stats_update_io_add(struct bfq_group *bfqg, struct bfq_queue *bfqq,
> - blk_opf_t opf);
> void bfqg_stats_update_io_remove(struct bfq_group *bfqg, blk_opf_t opf);
> void bfqg_stats_update_io_merged(struct bfq_group *bfqg, blk_opf_t opf);
> void bfqg_stats_update_completion(struct bfq_group *bfqg, u64 start_time_ns,
> u64 io_start_time_ns, blk_opf_t opf);
> void bfqg_stats_update_dequeue(struct bfq_group *bfqg);
> -void bfqg_stats_set_start_empty_time(struct bfq_group *bfqg);
> -void bfqg_stats_update_idle_time(struct bfq_group *bfqg);
> void bfqg_stats_set_start_idle_time(struct bfq_group *bfqg);
> -void bfqg_stats_update_avg_queue_size(struct bfq_group *bfqg);
> void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq,
> struct bfq_group *bfqg);
>
> +#ifdef CONFIG_BFQ_CGROUP_DEBUG
> +void bfqg_stats_update_io_add(struct bfq_group *bfqg, struct bfq_queue *bfqq,
> + blk_opf_t opf);
> +void bfqg_stats_set_start_empty_time(struct bfq_group *bfqg);
> +void bfqg_stats_update_idle_time(struct bfq_group *bfqg);
> +void bfqg_stats_update_avg_queue_size(struct bfq_group *bfqg);
> +#endif
> +
> void bfq_init_entity(struct bfq_entity *entity, struct bfq_group *bfqg);
> void bfq_bic_update_cgroup(struct bfq_io_cq *bic, struct bio *bio);
> void bfq_end_wr_async(struct bfq_data *bfqd);
> --
> 2.31.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-08-17 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 1:56 [PATCH -next 0/3] bfq simple cleanups Yu Kuai
2022-08-16 1:56 ` [PATCH -next 1/3] block, bfq: remove unused functions Yu Kuai
2022-08-17 11:55 ` Jan Kara [this message]
2022-08-16 1:56 ` [PATCH -next 2/3] block, bfq: remove useless checking in bfq_put_queue() Yu Kuai
2022-08-17 11:54 ` Jan Kara
2022-08-16 1:56 ` [PATCH -next 3/3] block, bfq: remove useless parameter for bfq_add/del_bfqq_busy() Yu Kuai
2022-08-17 11:56 ` Jan Kara
2022-08-19 20:56 ` [PATCH -next 0/3] bfq simple cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817115501.bwfpvdgppwd4p55y@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®