From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH 5/5] ASoC: cs42l42: Use snd_soc_tdm_params_to_bclk()
Date: Wed, 17 Aug 2022 13:23:47 +0100 [thread overview]
Message-ID: <20220817122347.1356773-6-rf@opensource.cirrus.com> (raw)
In-Reply-To: <20220817122347.1356773-1-rf@opensource.cirrus.com>
Use the new snd_soc_tdm_params_to_bclk() helper function to
calculate the bclk. This function handles most of the previous
manipulation and makes the code tidier.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/soc/codecs/cs42l42.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c
index a84d873e29df..42cdb051e0fb 100644
--- a/sound/soc/codecs/cs42l42.c
+++ b/sound/soc/codecs/cs42l42.c
@@ -893,22 +893,21 @@ static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
unsigned int channels = params_channels(params);
unsigned int width = (params_width(params) / 8) - 1;
+ unsigned int slot_width = 0;
unsigned int val = 0;
int ret;
cs42l42->srate = params_rate(params);
- cs42l42->bclk = snd_soc_params_to_bclk(params);
-
- /* I2S frame always has 2 channels even for mono audio */
- if (channels == 1)
- cs42l42->bclk *= 2;
/*
* Assume 24-bit samples are in 32-bit slots, to prevent SCLK being
* more than assumed (which would result in overclocking).
*/
if (params_width(params) == 24)
- cs42l42->bclk = (cs42l42->bclk / 3) * 4;
+ slot_width = 32;
+
+ /* I2S frame always has multiple of 2 channels */
+ cs42l42->bclk = snd_soc_tdm_params_to_bclk(params, slot_width, 0, 2);
switch (substream->stream) {
case SNDRV_PCM_STREAM_CAPTURE:
--
2.30.2
next prev parent reply other threads:[~2022-08-17 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 12:23 [PATCH 0/5] ASoC: cs42l42: Some small code improvements Richard Fitzgerald
2022-08-17 12:23 ` [PATCH 1/5] ASoC: cs42l42: Don't include kernel.h Richard Fitzgerald
2022-08-17 12:23 ` [PATCH 2/5] ASoC: cs42l42: Add include dependencies to cs42l42.h Richard Fitzgerald
2022-08-17 12:23 ` [PATCH 3/5] ASoC: cs42l42: Move cs42l42_supply_names to .c file Richard Fitzgerald
2022-08-17 12:23 ` [PATCH 4/5] ASoC: cs42l42: Fix comment typo in cs42l42_slow_start_put() Richard Fitzgerald
2022-08-17 12:23 ` Richard Fitzgerald [this message]
2022-08-17 17:05 ` [PATCH 0/5] ASoC: cs42l42: Some small code improvements Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817122347.1356773-6-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®