From: kan.liang@linux.intel.com
To: acme@redhat.com, linux-kernel@vger.kernel.org
Cc: eranian@google.com, ak@linux.intel.com, namhyung@kernel.org,
irogers@google.com, Kan Liang <kan.liang@linux.intel.com>
Subject: [PATCH] perf evsel: Update the hint for the usage of the load latency event
Date: Wed, 17 Aug 2022 05:40:50 -0700 [thread overview]
Message-ID: <20220817124050.2351268-1-kan.liang@linux.intel.com> (raw)
From: Kan Liang <kan.liang@linux.intel.com>
The current message is not providing enough information. It's hard for
a user to figure out what's the auxiliary event.
Adding the event name of the auxiliary event in the hint. The user can
simply cut & paste.
Suggested-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
tools/perf/util/evsel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 4852089e1d79..0d1bb5c723e9 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3056,7 +3056,8 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
break;
case ENODATA:
return scnprintf(msg, size, "Cannot collect data source with the load latency event alone. "
- "Please add an auxiliary event in front of the load latency event.");
+ "Please add an auxiliary event in front of the load latency event. "
+ "For example, -e {mem-loads-aux,%s}.", evsel__name(evsel));
default:
break;
}
--
2.35.1
reply other threads:[~2022-08-17 12:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817124050.2351268-1-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®