From: Sun Ke <sunke32@huawei.com>
To: <dhowells@redhat.com>
Cc: <linux-cachefs@redhat.com>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <jefflexu@linux.alibaba.com>,
<sunke32@huawei.com>
Subject: [PATCH] cachefiles: fix error return code in cachefiles_ondemand_copen()
Date: Thu, 18 Aug 2022 17:49:39 +0800 [thread overview]
Message-ID: <20220818094939.1548183-1-sunke32@huawei.com> (raw)
If size < 0; open request will fail, but cachefiles_ondemand_copen return 0.
Fix to return a negative error code.
Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
fs/cachefiles/ondemand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
index 1fee702d5529..a31d3ff0ce5f 100644
--- a/fs/cachefiles/ondemand.c
+++ b/fs/cachefiles/ondemand.c
@@ -161,6 +161,7 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args)
if (!IS_ERR_VALUE(size))
size = -EINVAL;
req->error = size;
+ ret = -EINVAL;
goto out;
}
--
2.31.1
next reply other threads:[~2022-08-18 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 9:49 Sun Ke [this message]
2022-08-18 10:47 ` JeffleXu
2022-08-18 11:02 ` Sun Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818094939.1548183-1-sunke32@huawei.com \
--to=sunke32@huawei.com \
--cc=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®