From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC97FC25B0E for ; Fri, 19 Aug 2022 07:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347064AbiHSH0Y (ORCPT ); Fri, 19 Aug 2022 03:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347011AbiHSH0W (ORCPT ); Fri, 19 Aug 2022 03:26:22 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E56B4857EC for ; Fri, 19 Aug 2022 00:26:20 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 75AA15C01A5; Fri, 19 Aug 2022 03:26:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 19 Aug 2022 03:26:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660893978; x=1660980378; bh=PQvXEf0pFG 7expZxKH9DggF+3kgGD1xFEyOXSYF6w9A=; b=VfJqVXNp+l3F9PSdNy39DzmKcM q80vDt8WC4xeZgZgxyOFJjo1+Ao9hP0DZjCnApKGjwesoi9dkgJI4EQodKftmHc/ yOcdOgLcPsePShy0bD4hyWlzyiIbRxfS53icBhPpa2kRVky1eZcvdEZEZSXKWnPY XBiDA8uPpqr9gYw+03HzGWt5dooKsuMaZ+ppUiHulFM24W+30q8LtyZlCvuM7UFY SL7zJz/Wj7dRgOb7fVYMwfmuG4FhE75HWWBPjyH/+L65+XtN6zwmiZU6qpfYFA5u eFP0rwd/hIVEnioG6W1CfG6ADXfV85riM4UzRdGOebY/d9iyJzDL/kYXbI+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660893978; x=1660980378; bh=PQvXEf0pFG7expZxKH9DggF+3kgG D1xFEyOXSYF6w9A=; b=llwIaWhlKIho6AS0koZdRDSv9Cywh1zX+rX6dNfYHP/p 8g0C0+zRGw0eq+cpKgUVaVfiekXhKR7ooN0AuVLWrjruC/VAy11gtobKrZRJF+uH NwMU2VQUZCfW0yQgv9MWSesWxnc0Ydao4jGuxBOWnq977TNr8ep8ZVua5zxpOJjc 4rOi68pslC72QDYlS6F8XGgh+ncBO6dkyh/dMO6o+gqFMcuEzMdwFC3L8ccHg1YQ nxe40e9cMRA5TJPULKRvOvLQLJAggxrM9xGcAGqE7UlTiW4ijuzrNVWnI7oNFi65 J+03OWO+oDMirlypNMOEFTRJw/xFfcG1+e54mqsdxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeitddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepteefffefgfektdefgfeludfgtdejfeejvddttdekteeiffejvdfgheeh fffhvedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 19 Aug 2022 03:26:17 -0400 (EDT) Date: Fri, 19 Aug 2022 09:26:14 +0200 From: Maxime Ripard To: Danilo Krummrich Cc: daniel@ffwll.ch, airlied@linux.ie, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm-misc-next 2/3] drm/vc4: plane: protect device resources after removal Message-ID: <20220819072614.dthfuugbkk65o3ps@houat> References: <20220819002905.82095-1-dakr@redhat.com> <20220819002905.82095-3-dakr@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dcp2mqorp5d7a6ps" Content-Disposition: inline In-Reply-To: <20220819002905.82095-3-dakr@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dcp2mqorp5d7a6ps Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Aug 19, 2022 at 02:29:04AM +0200, Danilo Krummrich wrote: > (Hardware) resources which are bound to the driver and device lifecycle > must not be accessed after the device and driver are unbound. >=20 > However, the DRM device isn't freed as long as the last user closed it, > hence userspace can still call into the driver. >=20 > Therefore protect the critical sections which are accessing those > resources with drm_dev_enter() and drm_dev_exit(). Ah good catch, thanks > Fixes: 9872c7a31921 ("drm/vc4: plane: Switch to drmm_universal_plane_allo= c()") > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/vc4/vc4_drv.h | 1 + > drivers/gpu/drm/vc4/vc4_plane.c | 25 +++++++++++++++++++++++++ > 2 files changed, 26 insertions(+) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h > index 418a8242691f..80da9a9337cc 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.h > +++ b/drivers/gpu/drm/vc4/vc4_drv.h > @@ -341,6 +341,7 @@ struct vc4_hvs { > =20 > struct vc4_plane { > struct drm_plane base; > + struct drm_device *dev; That pointer already exists in struct drm_plane Looks good otherwise Maxime --dcp2mqorp5d7a6ps Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYv87EAAKCRDj7w1vZxhR xcKJAPoCGmGROyZVzyfQc6jLZJ6oE3b0TFvxgA60VBJRAcmBDgEAiPirDdNpKGTp AQey4Kx35gTUWmZmTGdYwv+h75x5KQU= =gwzs -----END PGP SIGNATURE----- --dcp2mqorp5d7a6ps--