From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <rafael@kernel.org>
Cc: <gregkh@linuxfoundation.org>
Subject: [PATCH -next] driver core: switch to use dev_err_probe()
Date: Fri, 19 Aug 2022 17:46:56 +0800 [thread overview]
Message-ID: <20220819094656.1945653-1-yangyingliang@huawei.com> (raw)
Use dev_err_probe() to simplify code and print error code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/base/core.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 753e7cca0f40..e51a09f9d0ec 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2507,11 +2507,9 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr,
int rc;
rc = kobject_synth_uevent(&dev->kobj, buf, count);
-
- if (rc) {
- dev_err(dev, "uevent: failed to send synthetic uevent\n");
- return rc;
- }
+ if (rc)
+ return dev_err_probe(dev, rc,
+ "uevent: failed to send synthetic uevent\n");
return count;
}
--
2.25.1
next reply other threads:[~2022-08-19 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 9:46 Yang Yingliang [this message]
2022-08-19 9:42 ` Greg KH
2022-08-22 2:10 ` Yang Yingliang
2022-08-22 6:09 ` Greg KH
2022-08-22 6:35 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819094656.1945653-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®