From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Masami Hiramatsu <mhiramat@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
linux-kbuild@vger.kernel.org, live-patching@vger.kernel.org,
lkp@intel.com, stable@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] kallsyms: add option to include relative filepaths into kallsyms
Date: Fri, 19 Aug 2022 12:50:01 +0200 [thread overview]
Message-ID: <20220819105001.1130876-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <Yv5IfiwqGumJwVGT@kroah.com>
From: Greg KH <gregkh@linuxfoundation.org>
Date: Thu, 18 Aug 2022 16:11:10 +0200
> On Thu, Aug 18, 2022 at 03:56:29PM +0200, Alexander Lobakin wrote:
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Date: Thu, 18 Aug 2022 14:23:43 +0200
> >
> > > On Thu, Aug 18, 2022 at 01:53:06PM +0200, Alexander Lobakin wrote:
> > > > Currently, kallsyms kernel code copes with symbols with the same
> > > > name by indexing them according to their position in vmlinux and
> > > > requiring to provide an index of the desired symbol. This is not
> > > > really quite reliable and is fragile to any features performing
> > > > symbol or section manipulations such as FG-KASLR.
> > >
> > > Ah, here's the reasoning, stuff like this should go into the 0/X message
> > > too, right?
> > >
> > > Anyway, what is currently broken that requires this? What will this
> > > make easier in the future? What in the future will depend on this?
> >
> > 2) FG-KASLR will depend and probably some more crazy hardening
> > stuff. And/or perf-based function/symbol placement, which is
> > in the "discuss and dream sometimes" stage.
>
> I have no idea what "FG-KASLR" is. Why not submit these changes when
> whatever that is is ready for submission?
It doesn't matter much, the main idea is that the current approach
with relying on symbol positions in the vmlinux is broken when we
reorder symbols during the kernel initialization.
As I said, this is an early RFC do discuss the idea and the
implementation. I could submit it along with FG-KASLR, but then if
there would be major change requests, I'd need to redo lots of
stuff, which is not very efficient. It's better to settle down the
implementation details in advance.
Plus this kallsyms feature goes standalone as it gets bigger. It
will contain a pack of commits and touch several different
subsystems. Mixing all of this with FG-KASLR in one series doesn't
sound good to me.
>
> thanks,
>
> greg k-h
Thanks,
Olek
next prev parent reply other threads:[~2022-08-19 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 11:53 [RFC PATCH 0/3] " Alexander Lobakin
2022-08-18 11:53 ` [RFC PATCH 1/3] modpost: fix TO_NATIVE() with expressions and consts Alexander Lobakin
2022-08-18 12:26 ` Greg KH
2022-08-18 14:01 ` Alexander Lobakin
2022-08-18 14:10 ` Greg KH
2022-08-18 15:07 ` Alexander Lobakin
2022-08-18 11:53 ` [RFC PATCH 2/3] [STUB] increase kallsyms length limit Alexander Lobakin
2022-08-18 12:23 ` Greg KH
2022-08-18 11:53 ` [RFC PATCH 3/3] kallsyms: add option to include relative filepaths into kallsyms Alexander Lobakin
2022-08-18 12:23 ` Greg KH
2022-08-18 13:56 ` Alexander Lobakin
2022-08-18 14:11 ` Greg KH
2022-08-19 10:50 ` Alexander Lobakin [this message]
2022-08-19 11:02 ` Greg KH
2022-08-19 15:00 ` Alexander Lobakin
2022-08-19 15:19 ` Greg KH
2022-08-18 12:20 ` [RFC PATCH 0/3] " Greg KH
2022-08-18 13:39 ` Alexander Lobakin
2022-08-22 14:40 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819105001.1130876-1-alexandr.lobakin@intel.com \
--to=alexandr.lobakin@intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=naveen.n.rao@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®