From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C9CC32771 for ; Fri, 19 Aug 2022 22:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240797AbiHSWTT (ORCPT ); Fri, 19 Aug 2022 18:19:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiHSWTH (ORCPT ); Fri, 19 Aug 2022 18:19:07 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F6B0D87C9 for ; Fri, 19 Aug 2022 15:19:03 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id r22so4707894pgm.5 for ; Fri, 19 Aug 2022 15:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=QUVq2AEfy4BLzc5ShfAzmaXa1lQpxGbdDm4GA683rSc=; b=ENdToelV8P3tTBi2wyMgiiiSSMF5hoMniphFi0mNyhiWmSB7WnKAAGDm0y249ftZx0 euJ59gUES9Sl1uGVN9rZFlMBBym+At5jN4QekFPo64wXRHssx1NA7mtKm5Zza9ebg/Mk 8RvsoBVQmiYFDka9tvNFAMmHimhVJcbfvX97A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=QUVq2AEfy4BLzc5ShfAzmaXa1lQpxGbdDm4GA683rSc=; b=7e7gIWv08l8IVFN6jicupedj2zjjGmQ9yE3DyxAxLe3trKqzYqBNGGHqswyA3W7N8R bEbLuWZM1Xg80rx+afjBzg+2ngm4FXBrPSQkQ9JiDq6eaHg2ogrsMYYZ4tghRPJUwwtm jqJBR2huWU8qp0rYg72KPFgCqkIiiiwS4Zf9vdHA6g26CMprcVsr4eV4ThOAsL87CI8m WrZ5fpCOa7Wp6buWvLy1qdO3Np8+AiIo+I8MPqkrrlJkpFHETJ0FczwCsUraPWuWy+6D l12SZlO+mIhb+7VveS7zKmHy170yOJGJMCft5p5Tj4CCBwJAPnQmooVfLNgZXE7apv4I yqTA== X-Gm-Message-State: ACgBeo1Ms/e0cSxfEBqNBjEgs6CrZtspTDiyZml1uW12Cp70pBaoW+Qk oDBF4vahVMCBclEo2tMiXaQMXg== X-Google-Smtp-Source: AA6agR5yjAIf5Xy45cDJTVjnFsujDKd9TTUypCIz7oBxdMnqx9LYIfaHcjwndscLsXmluc2KObcPhw== X-Received: by 2002:a05:6a00:10d3:b0:4fe:5d:75c8 with SMTP id d19-20020a056a0010d300b004fe005d75c8mr10058352pfu.6.1660947542596; Fri, 19 Aug 2022 15:19:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l9-20020a170902f68900b0016be96e07d1sm3570628plg.121.2022.08.19.15.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 15:19:02 -0700 (PDT) Date: Fri, 19 Aug 2022 15:19:01 -0700 From: Kees Cook To: Jack Wang Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , Leon Romanovsky , Christophe JAILLET , =?iso-8859-1?Q?H=E5kon?= Bugge , linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Message-ID: <202208191518.A550DF53BC@keescook> References: <20220819060801.10443-1-jinpu.wang@ionos.com> <20220819060801.10443-3-jinpu.wang@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220819060801.10443-3-jinpu.wang@ionos.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 08:07:44AM +0200, Jack Wang wrote: > dma_map_sg return 0 on error, in case of error set > EIO as return code. > > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Cc: Christophe JAILLET > Cc: Kees Cook > Cc: "Håkon Bugge" > Cc: linux-rdma@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Jack Wang Reviewed-by: Kees Cook -- Kees Cook