From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Tom Zanussi <zanussi@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/4] tracing/eprobes: Do not hardcode $comm as a string
Date: Fri, 19 Aug 2022 21:57:00 -0400 [thread overview]
Message-ID: <20220819215700.549b4dac@gandalf.local.home> (raw)
In-Reply-To: <20220820014833.035925907@goodmis.org>
On Fri, 19 Aug 2022 21:40:37 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> +++ b/kernel/trace/trace_probe.c
> @@ -622,9 +622,10 @@ static int traceprobe_parse_probe_arg_body(const char *argv, ssize_t *size,
>
> /*
> * Since $comm and immediate string can not be dereferenced,
> - * we can find those by strcmp.
> + * we can find those by strcmp. But ignore for eprobes.
> */
> - if (strcmp(arg, "$comm") == 0 || strncmp(arg, "\\\"", 2) == 0) {
> + if (!(flags & TPARG_FL_TPOINT) &&
> + strcmp(arg, "$comm") == 0 || strncmp(arg, "\\\"", 2) == 0) {
And my tests fail shortly after I send this. It complains about a new
warning. The above needs parenthesis around it.
Will send a v2 after my tests pass, in case it finds something else I
missed.
-- Steve
> /* The type of $comm must be "string", and not an array. */
> if (parg->count || (t && strcmp(t, "string")))
> goto out;
> --
next prev parent reply other threads:[~2022-08-20 1:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 1:40 [PATCH 0/4] tracing/eprobes: Fixes for unexpected arguments Steven Rostedt
2022-08-20 1:40 ` [PATCH 1/4] tracing/eprobes: Do not allow eprobes to use $stack, or % for regs Steven Rostedt
2022-08-20 8:33 ` Masami Hiramatsu
2022-08-20 1:40 ` [PATCH 2/4] tracing/eprobes: Do not hardcode $comm as a string Steven Rostedt
2022-08-20 1:57 ` Steven Rostedt [this message]
2022-08-20 11:18 ` Masami Hiramatsu
2022-08-20 12:48 ` Steven Rostedt
2022-08-20 13:00 ` Steven Rostedt
2022-08-20 13:09 ` Masami Hiramatsu
2022-08-20 13:19 ` Steven Rostedt
2022-08-20 1:40 ` [PATCH 3/4] tracing/eprobes: Fix reading of string fields Steven Rostedt
2022-08-20 12:27 ` Masami Hiramatsu
2022-08-20 1:40 ` [PATCH 4/4] tracing/eprobes: Have event probes be consistent with kprobes and uprobes Steven Rostedt
2022-08-20 13:04 ` Masami Hiramatsu
2022-08-20 13:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819215700.549b4dac@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®