From: kernel test robot <lkp@intel.com>
To: Hector Martin <marcan@marcan.st>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [asahilinux:bits/090-spi-hid 17/22] drivers/hid/dockchannel-hid/dockchannel-hid.c:303:28: error: implicit declaration of function 'FIELD_PREP'
Date: Sat, 20 Aug 2022 22:23:06 +0800 [thread overview]
Message-ID: <202208202234.aXbQ3aiF-lkp@intel.com> (raw)
tree: https://github.com/AsahiLinux/linux bits/090-spi-hid
head: 480924e97dddd088c4ed360eb12ecf92a30f19b1
commit: 1d801ad9c4b08a5675701e82f600d9f462211a79 [17/22] hid: Add Apple DockChannel HID transport driver
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220820/202208202234.aXbQ3aiF-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/AsahiLinux/linux/commit/1d801ad9c4b08a5675701e82f600d9f462211a79
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux bits/090-spi-hid
git checkout 1d801ad9c4b08a5675701e82f600d9f462211a79
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/hid/dockchannel-hid/dockchannel-hid.c: In function 'dchid_cmd':
>> drivers/hid/dockchannel-hid/dockchannel-hid.c:303:28: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
303 | iface->out_flags = FIELD_PREP(FLAGS_GROUP, type) | FIELD_PREP(FLAGS_REQ, req);
| ^~~~~~~~~~
In file included from include/linux/device.h:15,
from drivers/hid/dockchannel-hid/dockchannel-hid.c:10:
drivers/hid/dockchannel-hid/dockchannel-hid.c: In function 'dchid_handle_ready':
drivers/hid/dockchannel-hid/dockchannel-hid.c:569:37: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
569 | dev_err(dchid->dev, "Bad length for ready message: %ld\n", length);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:569:17: note: in expansion of macro 'dev_err'
569 | dev_err(dchid->dev, "Bad length for ready message: %ld\n", length);
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:569:70: note: format string is defined here
569 | dev_err(dchid->dev, "Bad length for ready message: %ld\n", length);
| ~~^
| |
| long int
| %d
drivers/hid/dockchannel-hid/dockchannel-hid.c: In function 'dchid_packet_work':
>> drivers/hid/dockchannel-hid/dockchannel-hid.c:825:20: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
825 | int type = FIELD_GET(FLAGS_GROUP, shdr->flags);
| ^~~~~~~~~
| FOLL_GET
drivers/hid/dockchannel-hid/dockchannel-hid.c:829:37: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=]
829 | dev_err(dchid->dev, "Bad sub header length (%d > %ld)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:829:17: note: in expansion of macro 'dev_err'
829 | dev_err(dchid->dev, "Bad sub header length (%d > %ld)\n",
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:829:68: note: format string is defined here
829 | dev_err(dchid->dev, "Bad sub header length (%d > %ld)\n",
| ~~^
| |
| long int
| %d
drivers/hid/dockchannel-hid/dockchannel-hid.c: In function 'dchid_handle_ack':
drivers/hid/dockchannel-hid/dockchannel-hid.c:855:44: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=]
855 | dev_err(iface->dchid->dev, "Bad sub header length (%d > %ld)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:855:17: note: in expansion of macro 'dev_err'
855 | dev_err(iface->dchid->dev, "Bad sub header length (%d > %ld)\n",
| ^~~~~~~
drivers/hid/dockchannel-hid/dockchannel-hid.c:855:75: note: format string is defined here
855 | dev_err(iface->dchid->dev, "Bad sub header length (%d > %ld)\n",
| ~~^
| |
| long int
| %d
drivers/hid/dockchannel-hid/dockchannel-hid.c: In function 'dockchannel_hid_probe':
drivers/hid/dockchannel-hid/dockchannel-hid.c:975:14: warning: variable 'defer' set but not used [-Wunused-but-set-variable]
975 | bool defer = false;
| ^~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +303 drivers/hid/dockchannel-hid/dockchannel-hid.c
292
293 static int dchid_cmd(struct dchid_iface *iface, u32 type, u32 req,
294 void *data, size_t size, void *resp_buf, size_t resp_size)
295 {
296 int ret;
297 int report_id = *(u8*)data;
298
299 mutex_lock(&iface->out_mutex);
300
301 WARN_ON(iface->out_report != -1);
302 iface->out_report = report_id;
> 303 iface->out_flags = FIELD_PREP(FLAGS_GROUP, type) | FIELD_PREP(FLAGS_REQ, req);
304 iface->resp_buf = resp_buf;
305 iface->resp_size = resp_size;
306 reinit_completion(&iface->out_complete);
307
308 ret = dchid_send(iface, iface->out_flags, data, size);
309 if (ret < 0)
310 goto done;
311
312 if (!wait_for_completion_timeout(&iface->out_complete, msecs_to_jiffies(1000))) {
313 dev_err(iface->dchid->dev, "output report 0x%x to iface %d (%s) timed out\n",
314 report_id, iface->index, iface->name);
315 ret = -ETIMEDOUT;
316 goto done;
317 }
318
319 ret = iface->resp_size;
320 if (iface->retcode) {
321 dev_err(iface->dchid->dev,
322 "output report 0x%x to iface %d (%s) failed with err 0x%x\n",
323 report_id, iface->index, iface->name, iface->retcode);
324 ret = -EIO;
325 }
326
327 done:
328 iface->tx_seq++;
329 iface->out_report = -1;
330 iface->out_flags = 0;
331 iface->resp_buf = NULL;
332 iface->resp_size = 0;
333 mutex_unlock(&iface->out_mutex);
334 return ret;
335 }
336
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-08-20 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 14:23 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-12 11:35 kernel test robot
2022-08-12 15:35 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208202234.aXbQ3aiF-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome