From: Chen Lifu <chenlifu@huawei.com>
To: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<linux-kernel@vger.kernel.org>
Cc: <chenlifu@huawei.com>
Subject: [PATCH -next] x86: i8259: Make default_legacy_pic static
Date: Tue, 23 Aug 2022 10:19:58 +0800 [thread overview]
Message-ID: <20220823021958.3052493-1-chenlifu@huawei.com> (raw)
The symbol is not used outside of the file, so mark it static.
Fixes the following warning:
arch/x86/kernel/i8259.c:410:19: warning:
symbol 'default_legacy_pic' was not declared. Should it be static?
Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
arch/x86/kernel/i8259.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 15aefa3f3e18..3aa5304200c5 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -405,11 +405,11 @@ struct legacy_pic null_legacy_pic = {
.probe = legacy_pic_probe,
.irq_pending = legacy_pic_irq_pending_noop,
.make_irq = legacy_pic_uint_noop,
};
-struct legacy_pic default_legacy_pic = {
+static struct legacy_pic default_legacy_pic = {
.nr_legacy_irqs = NR_IRQS_LEGACY,
.chip = &i8259A_chip,
.mask = mask_8259A_irq,
.unmask = unmask_8259A_irq,
.mask_all = mask_8259A,
--
2.37.1
next reply other threads:[~2022-08-23 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 2:19 Chen Lifu [this message]
2022-10-31 0:48 ` chenlifu
2022-10-31 9:29 ` [tip: x86/cleanups] x86/i8259: " tip-bot2 for Chen Lifu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823021958.3052493-1-chenlifu@huawei.com \
--to=chenlifu@huawei.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®