From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D8FECAA2B for ; Thu, 25 Aug 2022 19:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242611AbiHYTvv (ORCPT ); Thu, 25 Aug 2022 15:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbiHYTvs (ORCPT ); Thu, 25 Aug 2022 15:51:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8962B14D8 for ; Thu, 25 Aug 2022 12:51:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 74DE3B82A37 for ; Thu, 25 Aug 2022 19:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3242C433D6; Thu, 25 Aug 2022 19:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661457105; bh=bDsBSc9D8CFPAf1LMWVvP0gWEdVoQLURNx3YOde3SBM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FlIkg9gbsW+HqOTGN0GzpPd+NLGQNRpEjVBvVKM6O9oT3pkayfLNu0dRfzLVdbNYx V+U2jElo35qWP++HTF7we3ylR+wzW2Zx/z2Pfvmor5P9hfREziWPMAOmMd5wWsvlZh csqEWd8pWePUrSoXNE3zCKp8IuHDm5pwZpS9Uag5/e79ga3wHhNdoWvRb7fHwlHIC/ I7k9tTjxilv+9QoasbREmLYaIP5Pe5OAH3XEOxjFPfVderRcMswpVzcMkAD3C2BRE5 i+6cKpnN45QFzWeHKsfdtPiMw7ik3CMxloaLEFraBXhvb8pZtwKqKgk4rRUIvuyGQN f2q4J4qhERaMA== Date: Thu, 25 Aug 2022 14:51:43 -0500 From: Bjorn Helgaas To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, gregkh@linuxfoundation.org Subject: Re: [PATCH] earlyprintk: Clean up pciserial Message-ID: <20220825195143.GA2867872@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 09:36:35PM +0200, Peter Zijlstra wrote: > On Thu, Aug 25, 2022 at 12:39:59PM -0500, Bjorn Helgaas wrote: > > > > - (((classcode >> 8) & 0xff) != 0x02)) /* 16550 I/F at BAR0 */ { > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > > index 6feade66efdb..1d2c7df8cd41 100644 > > > --- a/include/linux/pci_ids.h > > > +++ b/include/linux/pci_ids.h > > > @@ -75,6 +75,9 @@ > > > #define PCI_CLASS_COMMUNICATION_MODEM 0x0703 > > > #define PCI_CLASS_COMMUNICATION_OTHER 0x0780 > > > > > > +/* I/F for SERIAL/MODEM */ > > > > I/F? Grep says it's fairly common, but doesn't seem completely > > obvious. I guess it means "interface"? > > It does, I carried the nomenclature from the above line; happy to change > it if you want. > > https://wiki.osdev.org/PCI#Class_Codes > > Calls it 'Prog IF'. Personally, I would spell it out just to make it less arcane. I wouldn't know where to find the definition, and the PCI specs don't seem to use the abbreviation. But no big deal either way. Bjorn