From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BEBAECAAA2 for ; Fri, 26 Aug 2022 01:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244177AbiHZBSo (ORCPT ); Thu, 25 Aug 2022 21:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235416AbiHZBSk (ORCPT ); Thu, 25 Aug 2022 21:18:40 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43E6C9E88; Thu, 25 Aug 2022 18:18:39 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MDMMF5WJbzkWgX; Fri, 26 Aug 2022 09:15:05 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 09:18:38 +0800 Received: from ubuntu1804.huawei.com (10.67.174.175) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 26 Aug 2022 09:18:37 +0800 From: Lu Jialin To: Zefan Li , Tejun Heo , "Johannes Weiner" , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song CC: Lu Jialin , Xiu Jianfeng , , , Subject: [RFC 1/2] cgroup: Introduce per-cgroup resource top show interface Date: Fri, 26 Aug 2022 09:15:02 +0800 Message-ID: <20220826011503.103894-2-lujialin4@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220826011503.103894-1-lujialin4@huawei.com> References: <20220826011503.103894-1-lujialin4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.175] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiu Jianfeng This patch introduces cgroup.top interface for each cgroup. When accessed by userspace, cgroup.top is able to: 1. Sort cgroups by their usage on various resources(e.g. memory, cpu, etc.) 2. Display resource usage status on all child cgroups. Signed-off-by: Xiu Jianfeng Co-developed-by: Lu Jialin Signed-off-by: Lu Jialin --- include/linux/cgroup-defs.h | 1 + kernel/cgroup/cgroup.c | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index 4bcf56b3491c..ba11e09f8f03 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -651,6 +651,7 @@ struct cgroup_subsys { int (*css_extra_stat_show)(struct seq_file *seq, struct cgroup_subsys_state *css); + void (*css_top)(struct cgroup_subsys_state *css, struct seq_file *seq); int (*can_attach)(struct cgroup_taskset *tset); void (*cancel_attach)(struct cgroup_taskset *tset); void (*attach)(struct cgroup_taskset *tset); diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index ffaccd6373f1..01bd1a734a01 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -3867,6 +3867,22 @@ static ssize_t cgroup_kill_write(struct kernfs_open_file *of, char *buf, return ret ?: nbytes; } +static int cgroup_top_show(struct seq_file *seq, void *v) +{ + struct cgroup *cgrp = seq_css(seq)->cgroup; + struct cgroup_subsys_state *css; + int ssid; + + rcu_read_lock(); + for_each_css(css, ssid, cgrp) { + if (css->ss->css_top) + css->ss->css_top(css, seq); + } + rcu_read_unlock(); + + return 0; +} + static int cgroup_file_open(struct kernfs_open_file *of) { struct cftype *cft = of_cft(of); @@ -5125,6 +5141,10 @@ static struct cftype cgroup_base_files[] = { .release = cgroup_pressure_release, }, #endif /* CONFIG_PSI */ + { + .name = "cgroup.top", + .seq_show = cgroup_top_show, + }, { } /* terminate */ }; -- 2.17.1