From: Jonathan Cameron <jic23@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel <kernel@axis.com>, Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: buffer: Silence lock nesting splat
Date: Sun, 28 Aug 2022 16:32:47 +0100 [thread overview]
Message-ID: <20220828163247.3d6417d9@jic23-huawei> (raw)
In-Reply-To: <YwSLhWFbGb26B3mx@axis.com>
On Tue, 23 Aug 2022 10:10:45 +0200
Vincent Whitchurch <vincent.whitchurch@axis.com> wrote:
> On Sat, Aug 20, 2022 at 01:08:00PM +0200, Jonathan Cameron wrote:
> > On Fri, 19 Aug 2022 11:03:55 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On top of that, Fixes tag?
> > It's going to be tricky to identify - the interface predates usecases that were IIO
> > drivers by a long way. I guess introduction of first IIO driver that used
> > a callback buffer? No idea which one that was :(
>
> AFAICS there's only one IIO driver upstream using a callback buffer, and
> it's lmp91000, so I can point the fixes tag to the patch which added
> that.
Ah. That's handy.
>
> By the way, note that lmp91000 actually fails to probe in mainline
> without extra patches, and it seems to have been that way for a while
> now. I noticed this lockdep splat when working on a new driver which
> also uses a callback buffer. I can post the fixes I used to get
> lmp91000 to probe successfully (in roadtest) separately.
That would be great. Unfortunately drivers sometimes bit rot
without testing.
Any plans to post updated roadtest soon? I'm keen to add more test cases
and use it to cleanup the remaining staging drivers. Very helpful tool,
but I don't want to be developing test sets against an old version if
it's going to be costly to forward port it. No great rush though as
I've bitten off a bit more than I was aiming to in prep for plumbers so
not going to get anything significant done in IIO until mid September.
Thanks,
Jonathan
next prev parent reply other threads:[~2022-08-28 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 8:08 Vincent Whitchurch
2022-08-19 8:03 ` Andy Shevchenko
2022-08-20 11:08 ` Jonathan Cameron
2022-08-23 8:10 ` Vincent Whitchurch
2022-08-28 15:32 ` Jonathan Cameron [this message]
2022-09-01 7:04 ` Vincent Whitchurch
2022-08-20 11:06 ` Jonathan Cameron
2022-08-20 11:08 ` Lars-Peter Clausen
2022-08-23 8:12 ` Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220828163247.3d6417d9@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®