From: Li Zhong <floridsleeves@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
lily <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers/base/auxiliary: check return value of strrchr()
Date: Sun, 28 Aug 2022 13:40:40 -0700 [thread overview]
Message-ID: <20220828204040.1953493-1-floridsleeves@gmail.com> (raw)
From: lily <floridsleeves@gmail.com>
The return value of strrchr() could be NULL, which will cause invalid
offset in (int)(p - name). So we check it here.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/base/auxiliary.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
index 8c5e65930617..7ac23be47e1f 100644
--- a/drivers/base/auxiliary.c
+++ b/drivers/base/auxiliary.c
@@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, struct kobj_uevent_env *env)
name = dev_name(dev);
p = strrchr(name, '.');
-
+ if (!p)
+ return -EINVAL;
return add_uevent_var(env, "MODALIAS=%s%.*s", AUXILIARY_MODULE_PREFIX,
(int)(p - name), name);
}
--
2.25.1
next reply other threads:[~2022-08-28 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 20:40 Li Zhong [this message]
2022-09-01 15:05 ` Greg KH
2022-09-03 6:25 Li Zhong
2022-09-03 6:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220828204040.1953493-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®