From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67913C0502E for ; Mon, 29 Aug 2022 16:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbiH2QVq (ORCPT ); Mon, 29 Aug 2022 12:21:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbiH2QVR (ORCPT ); Mon, 29 Aug 2022 12:21:17 -0400 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA2A169F46; Mon, 29 Aug 2022 09:21:14 -0700 (PDT) Date: Mon, 29 Aug 2022 18:21:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661790073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V84lDEZ16EblHvtM8fgyVev0owrVHxHzScy/ND3jaaQ=; b=CaPKCCVzoPf4bcbSMTSpQx2lOZ5yESWOlPHBTiOGHy4YQpHkCtql8IPuRRpSByvC5hO8de 6xl8kO3jvz+Vdxt6cwkLhNUnQ9HU+hkqAyGXbfk+QrVReKpiqR0UixIQTF6rHD9/2AuqXA G+ANmKWFLtjqyg/LGkmx1D+5lFNxgSE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Nathan Chancellor , Nick Desaulniers , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , Tom Rix , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Colton Lewis , Peter Gonda Subject: Re: [PATCH v5 6/7] KVM: selftest: Drop now-unnecessary ucall_uninit() Message-ID: <20220829162111.wl65dxexk5qtrssf@kamzik> References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-7-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825232522.3997340-7-seanjc@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 11:25:21PM +0000, Sean Christopherson wrote: > Drop ucall_uninit() and ucall_arch_uninit() now that ARM doesn't modify > the host's copy of ucall_exit_mmio_addr, i.e. now that there's no need to > reset the pointer before potentially creating a new VM. The few calls to > ucall_uninit() are all immediately followed by kvm_vm_free(), and that is > likely always going to hold true, i.e. it's extremely unlikely a test > will want to effectively disable ucall in the middle of a test. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/dirty_log_test.c | 1 - > tools/testing/selftests/kvm/include/ucall_common.h | 6 ------ > tools/testing/selftests/kvm/kvm_page_table_test.c | 1 - > tools/testing/selftests/kvm/lib/aarch64/ucall.c | 14 ++------------ > tools/testing/selftests/kvm/lib/perf_test_util.c | 1 - > tools/testing/selftests/kvm/lib/riscv/ucall.c | 4 ---- > tools/testing/selftests/kvm/lib/s390x/ucall.c | 4 ---- > tools/testing/selftests/kvm/lib/x86_64/ucall.c | 4 ---- > 8 files changed, 2 insertions(+), 33 deletions(-) > Reviewed-by: Andrew Jones