From: Bjorn Andersson <andersson@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] soc: qcom: socinfo: create soc_id table from bindings
Date: Mon, 29 Aug 2022 15:49:30 -0500 [thread overview]
Message-ID: <20220829204930.27wg2htgbq23kgeg@builder.lan> (raw)
In-Reply-To: <20220705130300.100882-3-krzysztof.kozlowski@linaro.org>
On Tue, Jul 05, 2022 at 03:02:59PM +0200, Krzysztof Kozlowski wrote:
> The Qualcomm SoC ID values are encoded in few places: DTS files,
> Devicetree bindings (both used by some of Qualcomm bootloaders or tools)
> and in soc_id table of socinfo driver. Do not duplicate the actual
> values in the last one but use the constants from the bindings.
>
> Tested by comparing output object file (exactly the same).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I didn't have a strong opinion either way on this, so was hoping someone
else would chime in. Doesn't seem like that has happened, but
unfortunately the soc_id[] list has changed.
Would you mind rebasing the two patches to match the latest list?
> ---
> drivers/soc/qcom/socinfo.c | 259 +++++++++++++++++++------------------
> 1 file changed, 133 insertions(+), 126 deletions(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index cee579a267a6..d515d3a97f0e 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -12,11 +12,14 @@
> #include <linux/slab.h>
> #include <linux/soc/qcom/smem.h>
> #include <linux/string.h>
> +#include <linux/stringify.h>
> #include <linux/sys_soc.h>
> #include <linux/types.h>
>
> #include <asm/unaligned.h>
>
> +#include <dt-bindings/arm/qcom,ids.h>
> +
> /*
> * SoC version type with major number in the upper 16 bits and minor
> * number in the lower 16 bits.
> @@ -25,6 +28,10 @@
> #define SOCINFO_MINOR(ver) ((ver) & 0xffff)
> #define SOCINFO_VERSION(maj, min) ((((maj) & 0xffff) << 16)|((min) & 0xffff))
>
> +/* Helper macros to create soc_id table */
> +#define qcom_board_id(id) QCOM_ID_ ## id, __stringify(id)
> +#define qcom_board_id2(id, name) QCOM_ID_ ## id, (name)
How about naming this qcom_board_id_named() ?
Regards,
Bjorn
next prev parent reply other threads:[~2022-08-29 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 13:02 [PATCH v6 0/3] dt-bindings: arm: qcom: qcom,board-id and qcom,msm-id Krzysztof Kozlowski
2022-07-05 13:02 ` [PATCH v6 1/3] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id Krzysztof Kozlowski
2022-07-06 14:45 ` Rob Herring
2022-07-05 13:02 ` [PATCH v6 2/3] soc: qcom: socinfo: create soc_id table from bindings Krzysztof Kozlowski
2022-08-29 20:49 ` Bjorn Andersson [this message]
2022-08-30 6:13 ` Krzysztof Kozlowski
2022-07-05 13:03 ` [PATCH v6 3/3] arm64: dts: qcom: msm8992-xiaomi-libra: split qcom,msm-id into tuples Krzysztof Kozlowski
2022-08-29 23:45 ` (subset) [PATCH v6 0/3] dt-bindings: arm: qcom: qcom,board-id and qcom,msm-id Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829204930.27wg2htgbq23kgeg@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®