From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 3/4] serial: Convert serial_rs485 to kernel doc
Date: Tue, 30 Aug 2022 10:29:55 +0300 [thread overview]
Message-ID: <20220830072956.3630-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20220830072956.3630-1-ilpo.jarvinen@linux.intel.com>
Convert struct serial_rs485 comments to kernel doc format.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
include/uapi/linux/serial.h | 61 ++++++++++++++++++++++++-------------
1 file changed, 40 insertions(+), 21 deletions(-)
diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
index cea06924b295..dbdc7865abdc 100644
--- a/include/uapi/linux/serial.h
+++ b/include/uapi/linux/serial.h
@@ -107,37 +107,56 @@ struct serial_icounter_struct {
int reserved[9];
};
-/*
+/**
+ * struct serial_rs485 - serial interface for controlling RS485 settings.
+ * @flags: RS485 feature flags
+ * @delay_rts_before_send: Delay before send (milliseconds)
+ * @delay_rts_after_send: Delay after send (milliseconds)
+ * @addr_recv: Receive filter for RS485 addressing mode
+ * (used only when %SER_RS485_ADDR_RECV is set).
+ * @addr_dest: Destination address for RS485 addressing mode
+ * (used only when %SER_RS485_ADDR_DEST is set).
+ * @padding0: Padding (set to zero).
+ * @padding1: Padding (set to zero).
+ * @padding: Deprecated, use @padding0 and @padding1 instead.
+ * Do not use with @addr_recv and @addr_dest (due to
+ * overlap).
+ *
* Serial interface for controlling RS485 settings on chips with suitable
* support. Set with TIOCSRS485 and get with TIOCGRS485 if supported by your
* platform. The set function returns the new state, with any unsupported bits
* reverted appropriately.
+ *
+ * serial_rs485::flags bits are:
+ * * %SER_RS485_ENABLED - RS485 enabled
+ * * %SER_RS485_RTS_ON_SEND - Logical level for RTS pin when sending
+ * * %SER_RS485_RTS_AFTER_SEND - Logical level for RTS pin after sent
+ * * %SER_RS485_RX_DURING_TX - Full-duplex RS485 line
+ * * %SER_RS485_TERMINATE_BUS - Enable bus termination (if supported)
+ * * %SER_RS485_ADDRB - Enable RS485 addressing mode
+ * * %SER_RS485_ADDR_RECV - Receive address filter (enables @addr_recv).
+ * Requires %SER_RS485_ADDRB.
+ * * %SER_RS485_ADDR_DEST - Destination address (enables @addr_dest).
+ * Requires %SER_RS485_ADDRB.
*/
-
struct serial_rs485 {
- __u32 flags; /* RS485 feature flags */
-#define SER_RS485_ENABLED (1 << 0) /* If enabled */
-#define SER_RS485_RTS_ON_SEND (1 << 1) /* Logical level for
- RTS pin when
- sending */
-#define SER_RS485_RTS_AFTER_SEND (1 << 2) /* Logical level for
- RTS pin after sent*/
+ __u32 flags;
+#define SER_RS485_ENABLED (1 << 0)
+#define SER_RS485_RTS_ON_SEND (1 << 1)
+#define SER_RS485_RTS_AFTER_SEND (1 << 2)
#define SER_RS485_RX_DURING_TX (1 << 4)
-#define SER_RS485_TERMINATE_BUS (1 << 5) /* Enable bus
- termination
- (if supported) */
-
-/* RS-485 addressing mode */
-#define SER_RS485_ADDRB (1 << 6) /* Enable addressing mode */
-#define SER_RS485_ADDR_RECV (1 << 7) /* Receive address filter */
-#define SER_RS485_ADDR_DEST (1 << 8) /* Destination address */
+#define SER_RS485_TERMINATE_BUS (1 << 5)
+#define SER_RS485_ADDRB (1 << 6)
+#define SER_RS485_ADDR_RECV (1 << 7)
+#define SER_RS485_ADDR_DEST (1 << 8)
- __u32 delay_rts_before_send; /* Delay before send (milliseconds) */
- __u32 delay_rts_after_send; /* Delay after send (milliseconds) */
+ __u32 delay_rts_before_send;
+ __u32 delay_rts_after_send;
- /* The fields below are defined by flags */
+ /* private: The fields below are defined by flags */
union {
- __u32 padding[5]; /* Memory is cheap, new structs are a pain */
+ /* private: Memory is cheap, new structs are a pain. */
+ __u32 padding[5];
struct {
__u8 addr_recv;
--
2.30.2
next prev parent reply other threads:[~2022-08-30 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 7:29 [PATCH v2 0/4] serial: Create kserial_rs485 to get rid of padding Ilpo Järvinen
2022-08-30 7:29 ` [PATCH v2 1/4] serial: Rename vars in uart_get_rs485_config() Ilpo Järvinen
2022-08-30 8:54 ` Greg Kroah-Hartman
2022-08-30 9:03 ` Ilpo Järvinen
2022-08-30 7:29 ` [PATCH v2 2/4] serial: add helpers to copy serial_rs485 from/to userspace Ilpo Järvinen
2022-08-30 7:29 ` Ilpo Järvinen [this message]
2022-08-30 7:29 ` [PATCH v2 4/4] serial: Add kserial_rs485 to avoid wasted space due to .padding Ilpo Järvinen
2022-08-30 8:01 ` Jiri Slaby
2022-08-30 8:44 ` Ilpo Järvinen
2022-08-30 8:49 ` Greg Kroah-Hartman
2022-08-30 9:34 ` Ilpo Järvinen
2022-08-30 8:52 ` Greg Kroah-Hartman
2022-08-30 9:26 ` Ilpo Järvinen
2022-08-30 9:33 ` Greg Kroah-Hartman
2022-08-30 10:14 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830072956.3630-4-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®