From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6FDECAAD4 for ; Wed, 31 Aug 2022 11:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbiHaLNP (ORCPT ); Wed, 31 Aug 2022 07:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230468AbiHaLNL (ORCPT ); Wed, 31 Aug 2022 07:13:11 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA363D0228; Wed, 31 Aug 2022 04:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661944389; x=1693480389; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZXYlj1IqxZaV4DXbBX1YoGEIIdFLaXU6ViVzynme9rE=; b=EqsvE2y2OIrhxVfvacZwcJMO8qX4+Nj9bpy5TuqSYh8465koGxwd2jkH gbFZ1vRJnUQLcxbpa0e+EIjQLh9rcK0ssHJERzGQfncXgG7yILrzOddEo NplAgX186sw2v/jE5e++bbITaOrsagWYJynpPOl9gh8m8EEFgcNnGPQiH 1oJoLDjH8nyUuSPD7RxV11TUlcNjymttLha90l0etVeECfDTM9Y37aEWB 3zT9X+S5EHG1FsI5LZUXlT66qE/lArmik0KCQTPEx7CAg5QjqJjZcWnKU DbVtlN11AgHREIKqLdbhqMZXyb07I8rP1xTHBhDGQEWicwvrRY+2e1BH6 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="359383043" X-IronPort-AV: E=Sophos;i="5.93,277,1654585200"; d="scan'208";a="359383043" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 04:13:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,277,1654585200"; d="scan'208";a="701332161" Received: from lkp-server02.sh.intel.com (HELO 811e2ceaf0e5) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2022 04:13:06 -0700 Received: from kbuild by 811e2ceaf0e5 with local (Exim 4.96) (envelope-from ) id 1oTLeb-0000Di-1k; Wed, 31 Aug 2022 11:13:05 +0000 Date: Wed, 31 Aug 2022 19:12:34 +0800 From: kernel test robot To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Paolo Bonzini Cc: kbuild-all@lists.01.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Like Xu Subject: Re: [PATCH v3 3/3] KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs Message-ID: <202208311831.zQ4oCG1b-lkp@intel.com> References: <20220831000051.4015031-4-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831000051.4015031-4-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on 372d07084593dc7a399bf9bee815711b1fb1bcf2] url: https://github.com/intel-lab-lkp/linux/commits/Sean-Christopherson/KVM-x86-Intel-LBR-related-perf-cleanups/20220831-080309 base: 372d07084593dc7a399bf9bee815711b1fb1bcf2 config: i386-randconfig-s001 (https://download.01.org/0day-ci/archive/20220831/202208311831.zQ4oCG1b-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/094f42374997562fff3f9f9637ec9aa8257490a0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sean-Christopherson/KVM-x86-Intel-LBR-related-perf-cleanups/20220831-080309 git checkout 094f42374997562fff3f9f9637ec9aa8257490a0 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 prepare If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from arch/x86/kernel/../kvm/vmx/vmx.h:11, from arch/x86/kernel/asm-offsets.c:22: arch/x86/kernel/../kvm/vmx/capabilities.h: In function 'vmx_get_perf_capabilities': >> arch/x86/kernel/../kvm/vmx/capabilities.h:416:9: error: implicit declaration of function 'x86_perf_get_lbr' [-Werror=implicit-function-declaration] 416 | x86_perf_get_lbr(&lbr); | ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1207: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:222: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/x86_perf_get_lbr +416 arch/x86/kernel/../kvm/vmx/capabilities.h 403 404 static inline u64 vmx_get_perf_capabilities(void) 405 { 406 u64 perf_cap = PMU_CAP_FW_WRITES; 407 struct x86_pmu_lbr lbr; 408 u64 host_perf_cap = 0; 409 410 if (!enable_pmu) 411 return 0; 412 413 if (boot_cpu_has(X86_FEATURE_PDCM)) 414 rdmsrl(MSR_IA32_PERF_CAPABILITIES, host_perf_cap); 415 > 416 x86_perf_get_lbr(&lbr); 417 if (lbr.nr) 418 perf_cap |= host_perf_cap & PMU_CAP_LBR_FMT; 419 420 if (vmx_pebs_supported()) { 421 perf_cap |= host_perf_cap & PERF_CAP_PEBS_MASK; 422 if ((perf_cap & PERF_CAP_PEBS_FORMAT) < 4) 423 perf_cap &= ~PERF_CAP_PEBS_BASELINE; 424 } 425 426 return perf_cap; 427 } 428 -- 0-DAY CI Kernel Test Service https://01.org/lkp