From: Yipeng Zou <zouyipeng@huawei.com>
To: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<rostedt@goodmis.org>, <mingo@redhat.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>
Cc: <liaochang1@huawei.com>, <chris.zjh@huawei.com>, <zouyipeng@huawei.com>
Subject: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
Date: Thu, 1 Sep 2022 18:45:15 +0800 [thread overview]
Message-ID: <20220901104515.135162-3-zouyipeng@huawei.com> (raw)
In-Reply-To: <20220901104515.135162-1-zouyipeng@huawei.com>
Use trace_hardirqs_on_caller to improve irq_tracing message.
lockdep log in riscv showing the last {enabled,disabled} at
__trace_hardirqs_{on,off} all the time(if called by).
But that's not what we want to see, the caller is what we want.
Before this commit:
[ 57.853175] hardirqs last enabled at (2519): __trace_hardirqs_on+0xc/0x14
[ 57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14
After this commit
[ 53.781428] hardirqs last enabled at (2595): restore_all+0xe/0x66
[ 53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10
Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
---
arch/riscv/kernel/trace_irq.c | 4 ++--
include/linux/irqflags.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c
index 095ac976d7da..7ca24b26e19f 100644
--- a/arch/riscv/kernel/trace_irq.c
+++ b/arch/riscv/kernel/trace_irq.c
@@ -16,12 +16,12 @@
void __trace_hardirqs_on(void)
{
- trace_hardirqs_on();
+ trace_hardirqs_on_caller(CALLER_ADDR0);
}
NOKPROBE_SYMBOL(__trace_hardirqs_on);
void __trace_hardirqs_off(void)
{
- trace_hardirqs_off();
+ trace_hardirqs_off_caller(CALLER_ADDR0);
}
NOKPROBE_SYMBOL(__trace_hardirqs_off);
diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index 5ec0fa71399e..46774fa85cde 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
extern void trace_hardirqs_off_finish(void);
extern void trace_hardirqs_on(void);
extern void trace_hardirqs_off(void);
+extern void trace_hardirqs_on_caller(unsigned long caller_addr);
+extern void trace_hardirqs_off_caller(unsigned long caller_addr);
# define lockdep_hardirq_context() (raw_cpu_read(hardirq_context))
# define lockdep_softirq_context(p) ((p)->softirq_context)
--
2.17.1
next prev parent reply other threads:[~2022-09-01 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 10:45 [PATCH 0/2] " Yipeng Zou
2022-09-01 10:45 ` [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip Yipeng Zou
2022-09-07 1:12 ` Steven Rostedt
2022-09-01 10:45 ` Yipeng Zou [this message]
2022-09-09 9:40 ` [PATCH 2/2] riscv: tracing: Improve hardirq tracing message Yipeng Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901104515.135162-3-zouyipeng@huawei.com \
--to=zouyipeng@huawei.com \
--cc=aou@eecs.berkeley.edu \
--cc=chris.zjh@huawei.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®