mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abel Wu <wuyun.abel@bytedance.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@suse.de>,
	Vincent Guittot <vincent.guittot@linaro.org>
Cc: Josh Don <joshdon@google.com>, Chen Yu <yu.c.chen@intel.com>,
	Yicong Yang <yangyicong@huawei.com>,
	linux-kernel@vger.kernel.org, Abel Wu <wuyun.abel@bytedance.com>,
	Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH v2 2/5] sched/fair: avoid double search on same cpu
Date: Thu,  1 Sep 2022 21:11:04 +0800	[thread overview]
Message-ID: <20220901131107.71785-2-wuyun.abel@bytedance.com> (raw)
In-Reply-To: <20220901131107.71785-1-wuyun.abel@bytedance.com>

The prev cpu is checked at the beginning of SIS, and it's unlikely
to be idle before the second check in select_idle_smt(). So we'd
better focus on its SMT siblings.

Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
Reviewed-by: Josh Don <joshdon@google.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9657c7de5f57..1ad79aaaaf93 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6355,6 +6355,8 @@ static int select_idle_smt(struct task_struct *p, int target)
 	int cpu;
 
 	for_each_cpu_and(cpu, cpu_smt_mask(target), p->cpus_ptr) {
+		if (cpu == target)
+			continue;
 		if (available_idle_cpu(cpu) || sched_idle_cpu(cpu))
 			return cpu;
 	}
-- 
2.31.1


  reply	other threads:[~2022-09-01 13:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 13:11 [PATCH v2 1/5] sched/fair: remove redundant check in select_idle_smt Abel Wu
2022-09-01 13:11 ` Abel Wu [this message]
2022-09-01 13:11 ` [PATCH v2 3/5] sched/fair: remove useless check in select_idle_core Abel Wu
2022-09-01 13:11 ` [PATCH v2 4/5] sched/fair: default to false in test_idle_cores Abel Wu
2022-09-01 13:11 ` [PATCH v2 5/5] sched/fair: cleanup for SIS_PROP Abel Wu
2022-09-01 14:03   ` Mel Gorman
2022-09-02  3:28     ` Abel Wu
2022-09-07  7:59     ` Abel Wu
2022-09-07  8:51       ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220901131107.71785-2-wuyun.abel@bytedance.com \
    --to=wuyun.abel@bytedance.com \
    --cc=joshdon@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mgorman@techsingularity.net \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=yangyicong@huawei.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®