From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org, Marco Elver <elver@google.com>
Subject: [PATCH] perf test: Skip sigtrap test on old kernels
Date: Fri, 2 Sep 2022 17:02:10 -0700 [thread overview]
Message-ID: <20220903000210.1112014-1-namhyung@kernel.org> (raw)
If it runs on an old kernel, perf_event_open would fail because of the
new fields sigtrap and sig_data. Just skip the test if it failed.
Cc: Marco Elver <elver@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/tests/sigtrap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/sigtrap.c b/tools/perf/tests/sigtrap.c
index e32ece90e164..7057566e6ae4 100644
--- a/tools/perf/tests/sigtrap.c
+++ b/tools/perf/tests/sigtrap.c
@@ -140,6 +140,7 @@ static int test__sigtrap(struct test_suite *test __maybe_unused, int subtest __m
fd = sys_perf_event_open(&attr, 0, -1, -1, perf_event_open_cloexec_flag());
if (fd < 0) {
pr_debug("FAILED sys_perf_event_open(): %s\n", str_error_r(errno, sbuf, sizeof(sbuf)));
+ ret = TEST_SKIP;
goto out_restore_sigaction;
}
--
2.37.2.789.g6183377224-goog
next reply other threads:[~2022-09-03 0:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 0:02 Namhyung Kim [this message]
2022-09-03 6:52 ` Marco Elver
2022-09-06 12:45 ` Arnaldo Carvalho de Melo
2022-09-06 18:31 ` Namhyung Kim
2022-09-06 20:50 ` Marco Elver
2022-09-06 20:56 ` Arnaldo Carvalho de Melo
2022-09-06 22:52 ` Namhyung Kim
2022-09-26 15:06 ` James Clark
2022-09-26 16:19 ` Namhyung Kim
2022-09-27 8:48 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903000210.1112014-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=elver@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®