From: Andrew Jones <ajones@ventanamicro.com>
To: Jinyu Tang <tjytimi@163.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, conor.dooley@microchip.com,
anup@brainfault.org, alexandre.ghiti@canonical.com,
guoren@kernel.org, akpm@linux-foundation.org, heiko@sntech.de,
tongtiangen@huawei.com, sunnanyong@huawei.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
falcon@tinylab.org
Subject: Re: [PATCH v1] riscv : support update_mmu_tlb() for riscv
Date: Tue, 6 Sep 2022 16:41:26 +0200 [thread overview]
Message-ID: <20220906144126.3enx6y2mhevrc4ur@kamzik> (raw)
In-Reply-To: <20220906121921.8355-1-tjytimi@163.com>
On Tue, Sep 06, 2022 at 08:19:21PM +0800, Jinyu Tang wrote:
> Add macro definition to support updata_mmu_tlb() for riscv,
> this function is from commit:7df676974359 ("mm/memory.c:Update
> local TLB if PTE entry exists").
>
> Signed-off-by: Jinyu Tang <tjytimi@163.com>
> ---
> arch/riscv/include/asm/pgtable.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 7ec936910a96..84a791d54f95 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -418,6 +418,9 @@ static inline void update_mmu_cache(struct vm_area_struct *vma,
> local_flush_tlb_page(address);
> }
>
> +#define __HAVE_ARCH_UPDATE_MMU_TLB
^ just a single space here, please, as all the other
'define __HAVE's in this file
> +#define update_mmu_tlb update_mmu_cache
> +
> static inline void update_mmu_cache_pmd(struct vm_area_struct *vma,
> unsigned long address, pmd_t *pmdp)
> {
> --
> 2.30.2
This seems like the right thing to do, so
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
I'm curious if this patch is the result of debugging something? Or what
led you to post it?
Thanks,
drew
next prev parent reply other threads:[~2022-09-06 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:19 Jinyu Tang
2022-09-06 14:41 ` Andrew Jones [this message]
2022-09-06 15:25 ` Conor.Dooley
2022-09-18 5:39 ` Jinyu Tang
2022-09-18 5:43 ` Jinyu Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906144126.3enx6y2mhevrc4ur@kamzik \
--to=ajones@ventanamicro.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sunnanyong@huawei.com \
--cc=tjytimi@163.com \
--cc=tongtiangen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®