From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B40D9ECAAA1 for ; Wed, 7 Sep 2022 02:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiIGCDO (ORCPT ); Tue, 6 Sep 2022 22:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbiIGCDM (ORCPT ); Tue, 6 Sep 2022 22:03:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6FB78F97F for ; Tue, 6 Sep 2022 19:03:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7136BB81A07 for ; Wed, 7 Sep 2022 02:03:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E4E1C433C1; Wed, 7 Sep 2022 02:03:07 +0000 (UTC) Date: Tue, 6 Sep 2022 22:03:46 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Tom Zanussi , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms Message-ID: <20220906220346.53a9a623@gandalf.local.home> In-Reply-To: <166226474055.223837.13947085068863989044.stgit@devnote2> References: <166226473132.223837.9011128463174539022.stgit@devnote2> <166226474055.223837.13947085068863989044.stgit@devnote2> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Sep 2022 13:12:20 +0900 "Masami Hiramatsu (Google)" wrote: > From: Tom Zanussi > > The hitcount is treated specially in the histograms - since it's > always expected to be there regardless of whether the user specified > anything or not, it's always added as the first histogram value. > > Currently the code doesn't allow it to be added more than once as a > value, which is inconsistent with all the other possible values. It > would seem to be a pointless thing to want to do, but other features > being added such as percent and graph modifiers don't work properly > with the current hitcount restrictions. > > Fix this by allowing multiple hitcounts to be added. > > Signed-off-by: Tom Zanussi Hi Masami, When posting patches from other people, you still need to add your Signed-off-by, as that denotes the people who processed the patch before it made it into git. -- Steve