From: Li Zhong <floridsleeves@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, jpoimboe@kernel.org, jbaron@akamai.com,
rostedt@goodmis.org, ardb@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v2] arch/x86/kernel: check the return value of insn_decode_kernel()
Date: Wed, 7 Sep 2022 01:54:05 -0700 [thread overview]
Message-ID: <20220907085405.2317461-1-floridsleeves@gmail.com> (raw)
insn_decode() could fail and the insn.length could be invalid. So we
need to check the return value first.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
arch/x86/kernel/jump_label.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index f5b8ef02d172..59385700f579 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86/kernel/jump_label.c
@@ -20,9 +20,10 @@
int arch_jump_entry_size(struct jump_entry *entry)
{
struct insn insn = {};
+ int ret;
- insn_decode_kernel(&insn, (void *)jump_entry_code(entry));
- BUG_ON(insn.length != 2 && insn.length != 5);
+ ret = insn_decode_kernel(&insn, (void *)jump_entry_code(entry));
+ BUG_ON(ret < 0 || (insn.length != 2 && insn.length != 5));
return insn.length;
}
--
2.25.1
next reply other threads:[~2022-09-07 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 8:54 Li Zhong [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-07 8:52 Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907085405.2317461-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®