From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <zanussi@kernel.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms
Date: Wed, 7 Sep 2022 15:12:58 +0900 [thread overview]
Message-ID: <20220907151258.f7864399c05424d0a7a27747@kernel.org> (raw)
In-Reply-To: <20220906220346.53a9a623@gandalf.local.home>
On Tue, 6 Sep 2022 22:03:46 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sun, 4 Sep 2022 13:12:20 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > From: Tom Zanussi <zanussi@kernel.org>
> >
> > The hitcount is treated specially in the histograms - since it's
> > always expected to be there regardless of whether the user specified
> > anything or not, it's always added as the first histogram value.
> >
> > Currently the code doesn't allow it to be added more than once as a
> > value, which is inconsistent with all the other possible values. It
> > would seem to be a pointless thing to want to do, but other features
> > being added such as percent and graph modifiers don't work properly
> > with the current hitcount restrictions.
> >
> > Fix this by allowing multiple hitcounts to be added.
> >
> > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
>
> Hi Masami,
>
> When posting patches from other people, you still need to add your
> Signed-off-by, as that denotes the people who processed the patch before it
> made it into git.
Oops, I got it.
Please add my signed-off-by;
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-09-07 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 4:12 [PATCH v5 0/6] tracing/hist: Add percentage histogram suffixes Masami Hiramatsu (Google)
2022-09-04 4:12 ` [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms Masami Hiramatsu (Google)
2022-09-07 2:03 ` Steven Rostedt
2022-09-07 6:12 ` Masami Hiramatsu [this message]
2022-09-04 4:12 ` [PATCH v5 2/6] tracing: Fix to check event_mutex is held while accessing trigger list Masami Hiramatsu (Google)
2022-09-07 2:09 ` Steven Rostedt
2022-09-04 4:12 ` [PATCH v5 3/6] tracing: Add .percent suffix option to histogram values Masami Hiramatsu (Google)
2022-09-04 4:12 ` [PATCH v5 4/6] tracing: Add .graph suffix option to histogram value Masami Hiramatsu (Google)
2022-09-04 4:12 ` [PATCH v5 5/6] tracing: Add nohitcount option for suppressing display of raw hitcount Masami Hiramatsu (Google)
2022-09-04 4:13 ` [PATCH v5 6/6] tracing: docs: Update histogram doc for .percent/.graph and 'nohitcount' Masami Hiramatsu (Google)
2022-09-08 22:01 ` [PATCH v5 0/6] tracing/hist: Add percentage histogram suffixes Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907151258.f7864399c05424d0a7a27747@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®