mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <danielwa@cisco.com>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: xe-linux-external@cisco.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] driver: of: overlay: demote message to warning
Date: Wed,  7 Sep 2022 16:07:08 -0700	[thread overview]
Message-ID: <20220907230709.271889-1-danielwa@cisco.com> (raw)

This warning message shows by default on the vast majority of overlays
applied. Despite the text identifying this as a warning it is marked
with the loglevel for error. At Cisco we filter the loglevels to only
show error messages. We end up seeing this message but it's not really
an error.

For this reason it makes sense to demote the message to the warning
loglevel.

Cc: xe-linux-external@cisco.com
Signed-off-by: Daniel Walker <danielwa@cisco.com>
---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index bd8ff4df723d..4ae276ed9a65 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {
-- 
2.25.1


             reply	other threads:[~2022-09-07 23:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 23:07 Daniel Walker [this message]
2022-09-07 23:54 ` Frank Rowand
2022-09-08  0:35   ` Daniel Walker
2022-09-08 17:55     ` Frank Rowand
2022-09-12  6:45       ` Frank Rowand
2022-09-12 17:05         ` Daniel Walker
2022-09-12 20:32           ` Frank Rowand
2022-09-13  0:51             ` Daniel Walker
2022-09-16 22:47               ` Frank Rowand
2022-09-16 22:56                 ` Daniel Walker
2022-09-17  2:47                   ` Frank Rowand
2022-09-17  3:26                     ` Daniel Walker
2022-09-26 22:29                       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907230709.271889-1-danielwa@cisco.com \
    --to=danielwa@cisco.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh+dt@kernel.org \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®